From 17129d2c2902315bfa94aad57c7911cd47c22716 Mon Sep 17 00:00:00 2001 From: snuffy Date: Fri, 15 May 2015 13:05:52 +1000 Subject: chan_pjsip: Fix crash during off-nominal when no endpoint specified. Add missing return -1 when no endpoint name is specified. ASTERISK-25086 #close Reported by: snuffy Change-Id: I9de76c2935a1f4e3f0cffe97a670106f5605e89e --- channels/chan_pjsip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c index 1195f1614..14ba4a298 100644 --- a/channels/chan_pjsip.c +++ b/channels/chan_pjsip.c @@ -1864,6 +1864,7 @@ static int request(void *obj) if (ast_strlen_zero(endpoint_name)) { ast_log(LOG_ERROR, "Unable to create PJSIP channel with empty endpoint name\n"); req_data->cause = AST_CAUSE_CHANNEL_UNACCEPTABLE; + return -1; } else if (!(endpoint = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "endpoint", endpoint_name))) { ast_log(LOG_ERROR, "Unable to create PJSIP channel - endpoint '%s' was not found\n", endpoint_name); req_data->cause = AST_CAUSE_NO_ROUTE_DESTINATION; -- cgit v1.2.3