From 283bb15c16c383f14b60a503e655b708f9ed791e Mon Sep 17 00:00:00 2001 From: Joshua Colp Date: Sat, 21 Feb 2015 18:53:34 +0000 Subject: res_pjsip: Add a log message when creating a UAC dialog to a target URI that is invalid. ASTERISK-24499 #close Reported by: Rusty Newton ........ Merged revisions 432118 from http://svn.asterisk.org/svn/asterisk/branches/13 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@432119 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- res/res_pjsip.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/res/res_pjsip.c b/res/res_pjsip.c index 6db84b417..f063d7963 100644 --- a/res/res_pjsip.c +++ b/res/res_pjsip.c @@ -2240,6 +2240,7 @@ pjsip_dialog *ast_sip_create_dialog_uac(const struct ast_sip_endpoint *endpoint, { char enclosed_uri[PJSIP_MAX_URL_SIZE]; pj_str_t local_uri = { "sip:temp@temp", 13 }, remote_uri, target_uri; + pj_status_t res; pjsip_dialog *dlg = NULL; const char *outbound_proxy = endpoint->outbound_proxy; pjsip_tpselector selector = { .type = PJSIP_TPSELECTOR_NONE, }; @@ -2250,7 +2251,12 @@ pjsip_dialog *ast_sip_create_dialog_uac(const struct ast_sip_endpoint *endpoint, pj_cstr(&target_uri, uri); - if (pjsip_dlg_create_uac(pjsip_ua_instance(), &local_uri, NULL, &remote_uri, &target_uri, &dlg) != PJ_SUCCESS) { + res = pjsip_dlg_create_uac(pjsip_ua_instance(), &local_uri, NULL, &remote_uri, &target_uri, &dlg); + if (res != PJ_SUCCESS) { + if (res == PJSIP_EINVALIDURI) { + ast_log(LOG_ERROR, "Could not create dialog to endpoint '%s' as URI '%s' is not valid\n", + ast_sorcery_object_get_id(endpoint), uri); + } return NULL; } -- cgit v1.2.3