From 40ee6ed4f0057ec60396f4fc21fc3107d7b276d7 Mon Sep 17 00:00:00 2001 From: Alec L Davis Date: Sun, 28 Feb 2010 16:36:45 +0000 Subject: make unit test check for NULL folder, which then defaults to INBOX previous test, gave false level of assurance that code was healthy. (issue #16927) Reported by: alecdavis Patches: based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249449 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- apps/app_voicemail.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c index 089a63a16..f1bf4b866 100644 --- a/apps/app_voicemail.c +++ b/apps/app_voicemail.c @@ -11682,7 +11682,8 @@ AST_TEST_DEFINE(test_voicemail_msgcount) /* hasvm-old, hasvm-urgent, hasvm-new, ic-old, ic-urgent, ic-new, ic2-old, ic2-urgent, ic2-new, mc-old, mc-urgent, mc-new */ for (j = 0; j < 3; j++) { - if (ast_app_has_voicemail(testspec, folders[j]) != expected_results[i][0 + j]) { + /* folder[2] is INBOX, __has_voicemail will default back to INBOX */ + if (ast_app_has_voicemail(testspec, (j==2 ? NULL : folders[j])) != expected_results[i][0 + j]) { ast_test_status_update(test, "has_voicemail(%s, %s) returned %d and we expected %d\n", testspec, folders[j], ast_app_has_voicemail(testspec, folders[j]), expected_results[i][0 + j]); res = AST_TEST_FAIL; -- cgit v1.2.3