From 73b3c70a5fbd3665e428f26b64b0549c890e1955 Mon Sep 17 00:00:00 2001 From: Richard Mudgett Date: Thu, 8 Aug 2013 17:51:26 +0000 Subject: Remove some resolved or obsolete BUGBUG comments. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@396401 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- include/asterisk/bridge_features.h | 2 -- main/bridge.c | 2 -- main/channel_internal_api.c | 1 - main/features.c | 2 +- 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/include/asterisk/bridge_features.h b/include/asterisk/bridge_features.h index 0a3a21ede..7590d8af8 100644 --- a/include/asterisk/bridge_features.h +++ b/include/asterisk/bridge_features.h @@ -86,7 +86,6 @@ enum ast_bridge_builtin_feature { * parking slot to which it was parked. */ AST_BRIDGE_BUILTIN_PARKCALL, -/* BUGBUG does Monitor and/or MixMonitor require a two party bridge? MixMonitor is used by ConfBridge so maybe it doesn't. */ /*! * DTMF one-touch-record toggle using Monitor app. * @@ -174,7 +173,6 @@ enum ast_bridge_hook_type { AST_BRIDGE_HOOK_TYPE_TALK, }; -/* BUGBUG Need to be able to selectively remove DTMF, hangup, and interval hooks. */ /*! \brief Structure that is the essence of a feature hook. */ struct ast_bridge_hook { /*! Callback that is called when hook is tripped */ diff --git a/main/bridge.c b/main/bridge.c index 9a64b0ed6..b8f69fe3a 100644 --- a/main/bridge.c +++ b/main/bridge.c @@ -1482,7 +1482,6 @@ int ast_bridge_join(struct ast_bridge *bridge, ao2_ref(bridge_channel, -1); join_exit:; -/* BUGBUG this is going to cause problems for DTMF atxfer attended bridge between B & C. Maybe an ast_bridge_join_internal() that does not do the after bridge goto for this case. */ ast_bridge_run_after_callback(chan); if (!(ast_channel_softhangup_internal_flag(chan) & AST_SOFTHANGUP_ASYNCGOTO) && !ast_bridge_setup_after_goto(chan)) { @@ -1960,7 +1959,6 @@ int bridge_do_move(struct ast_bridge *dst_bridge, struct ast_bridge_channel *bri int was_in_bridge; int res = 0; -/* BUGBUG need bridge move stasis event and a success/fail event. */ if (bridge_channel->swap) { ast_debug(1, "Moving %p(%s) into bridge %s swapping with %s\n", bridge_channel, ast_channel_name(bridge_channel->chan), dst_bridge->uniqueid, diff --git a/main/channel_internal_api.c b/main/channel_internal_api.c index f40852f0b..122b8cfdf 100644 --- a/main/channel_internal_api.c +++ b/main/channel_internal_api.c @@ -193,7 +193,6 @@ struct ast_channel { unsigned short transfercapability; /*!< ISDN Transfer Capability - AST_FLAG_DIGITAL is not enough */ -/* BUGBUG the bridge pointer must change to an ast_channel_bridge pointer because it will never change while the channel is in the bridging system whereas the bridge could change. */ struct ast_bridge *bridge; /*!< Bridge this channel is participating in */ struct ast_bridge_channel *bridge_channel;/*!< The bridge_channel this channel is linked with. */ struct ast_timer *timer; /*!< timer object that provided timingfd */ diff --git a/main/features.c b/main/features.c index e2d668426..9e5dfddb3 100644 --- a/main/features.c +++ b/main/features.c @@ -792,7 +792,7 @@ static int setup_bridge_features_dynamic(struct ast_bridge_features *features, s return res; } -/* BUGBUG this really should be made a private function of bridging_basic.c after struct ast_call_feature is made an ao2 object. */ +/* BUGBUG this really should be made a private function of bridge_basic.c after struct ast_call_feature is made an ao2 object. */ int ast_bridge_channel_setup_features(struct ast_bridge_channel *bridge_channel) { int res = 0; -- cgit v1.2.3