From f9c6f692053ac865d46cbf8843ab810dc66cba67 Mon Sep 17 00:00:00 2001 From: Sean Bright Date: Thu, 7 Dec 2017 10:52:39 -0500 Subject: utils: Add convenience function for setting fd flags There are many places in the code base where we ignore the return value of fcntl() when getting/setting file descriptior flags. This patch introduces a convenience function that allows setting or clearing file descriptor flags and will also log an error on failure for later analysis. Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7 --- apps/app_ices.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'apps') diff --git a/apps/app_ices.c b/apps/app_ices.c index 4ca4b67c5..1194384d4 100644 --- a/apps/app_ices.c +++ b/apps/app_ices.c @@ -113,7 +113,6 @@ static int ices_exec(struct ast_channel *chan, const char *data) int fds[2]; int ms = -1; int pid = -1; - int flags; struct ast_format *oreadformat; struct ast_frame *f; char filename[256]=""; @@ -128,8 +127,7 @@ static int ices_exec(struct ast_channel *chan, const char *data) ast_log(LOG_WARNING, "Unable to create pipe\n"); return -1; } - flags = fcntl(fds[1], F_GETFL); - fcntl(fds[1], F_SETFL, flags | O_NONBLOCK); + ast_fd_set_flags(fds[1], O_NONBLOCK); ast_stopstream(chan); -- cgit v1.2.3