From 64ae2e1e2a017c72da0178e13930d486f6485edd Mon Sep 17 00:00:00 2001 From: David Vossel Date: Tue, 29 Jun 2010 20:44:05 +0000 Subject: send a 400 Bad Request on malformed sip request RFC 2361 section 24.4.1 send a 400 Bad Request if the request can not be understood due to malformed syntax. Currently we simply ignore a packet with a missing callid, to, from, or via header. Instead of ignoring we now send the 400 Bad request. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@272981 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- channels/chan_sip.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'channels') diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 18d40cc21..a87909de1 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -7002,8 +7002,14 @@ static struct sip_pvt *find_call(struct sip_request *req, struct sockaddr_in *si /* Call-ID, to, from and Cseq are required by RFC 3261. (Max-forwards and via too - ignored now) */ /* get_header always returns non-NULL so we must use ast_strlen_zero() */ if (ast_strlen_zero(callid) || ast_strlen_zero(to) || - ast_strlen_zero(from) || ast_strlen_zero(cseq)) + ast_strlen_zero(from) || ast_strlen_zero(cseq)) { + + /* RFC 3261 section 24.4.1. Send a 400 Bad Request if the request is malformed. */ + if (intended_method != SIP_RESPONSE && intended_method != SIP_ACK) { + transmit_response_using_temp(callid, sin, 1, intended_method, req, "400 Bad Request"); + } return NULL; /* Invalid packet */ + } if (sip_cfg.pedanticsipchecking) { /* In principle Call-ID's uniquely identify a call, but with a forking SIP proxy -- cgit v1.2.3