From 90bb0a3e105ec1f4ae871bb37bc2890560584e3d Mon Sep 17 00:00:00 2001 From: Richard Mudgett Date: Sat, 11 Nov 2017 13:01:47 -0600 Subject: core: Add cache_media_frames debugging option. The media frame cache gets in the way of finding use after free errors of media frames. Tools like valgrind and MALLOC_DEBUG don't know when a frame is released because it gets put into the cache instead of being freed. * Added the "cache_media_frames" option to asterisk.conf. Disabling the option helps track down media frame mismanagement when using valgrind or MALLOC_DEBUG. The cache gets in the way of determining if the frame is used after free and who freed it. NOTE: This option has no effect when Asterisk is compiled with the LOW_MEMORY compile time option enabled because the cache code does not exist. To disable the media frame cache simply disable the cache_media_frames option in asterisk.conf and restart Asterisk. Sample asterisk.conf setting: [options] cache_media_frames=no ASTERISK-27413 Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00 --- channels/iax2/parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'channels') diff --git a/channels/iax2/parser.c b/channels/iax2/parser.c index ec9d34608..6eda98260 100644 --- a/channels/iax2/parser.c +++ b/channels/iax2/parser.c @@ -1296,7 +1296,9 @@ void iax_frame_free(struct iax_frame *fr) ast_atomic_fetchadd_int(&frames, -1); #if !defined(LOW_MEMORY) - if (!fr->cacheable || !(iax_frames = ast_threadstorage_get(&frame_cache, sizeof(*iax_frames)))) { + if (!fr->cacheable + || !ast_opt_cache_media_frames + || !(iax_frames = ast_threadstorage_get(&frame_cache, sizeof(*iax_frames)))) { ast_free(fr); return; } -- cgit v1.2.3