From e43bc6634dc60ca897a848ca3301f52c74330279 Mon Sep 17 00:00:00 2001 From: Luigi Rizzo Date: Fri, 14 Apr 2006 14:08:19 +0000 Subject: This rather large commit changes the way modules are loaded. As partly documented in loader.c and include/asterisk/module.h, modules are now expected to return all of their methods and flags into a structure 'mod_data', and are normally loaded with RTLD_NOW | RTLD_LOCAL, so symbols are resolved immediately and conflicts should be less likely. Only in a small number of cases (res_*, typically) modules are loaded RTLD_GLOBAL, so they can export symbols. The core of the change is only the two files loader.c and include/asterisk/module.h, all the rest is simply adaptation of the existing modules to the new API, a rather mechanical (but believe me, time and finger-consuming!) process whose detail you can figure out by svn diff'ing any single module. Expect some minor compilation issue after this change, please report it on mantis http://bugs.digium.com/view.php?id=6968 so we collect all the feedback in one place. I am just sorry that this change missed SVN version number 20000! git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- codecs/codec_g723_1.c | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) (limited to 'codecs/codec_g723_1.c') diff --git a/codecs/codec_g723_1.c b/codecs/codec_g723_1.c index d6e1d1b22..00a5ca635 100644 --- a/codecs/codec_g723_1.c +++ b/codecs/codec_g723_1.c @@ -265,8 +265,6 @@ static struct ast_frame *lintog723_frameout(void *pvt) return ast_trans_frameout(pvt, cnt, samples); } -static struct ast_module_lock me = { .usecnt = -1 }; - static struct ast_translator g723tolin = { .name = #ifdef ANNEX_B @@ -280,7 +278,6 @@ static struct ast_translator g723tolin = { .framein = g723tolin_framein, .sample = g723tolin_sample, .desc_size = sizeof(struct ...), - .lockp = &me, }; static struct ast_translator lintog723 = { @@ -297,36 +294,31 @@ static struct ast_translator lintog723 = { .frameout = lintog723_frameout, .destroy = g723_destroy, .sample = lintog723_sample, - .lockp = &me, .desc_size = sizeof(struct ...), }; /*! \brief standard module glue */ -int unload_module(void) +static int unload_module(void *mod) { int res; - ast_mutex_lock(&me.lock); res = ast_unregister_translator(&lintog723); res |= ast_unregister_translator(&g723tolin); - if (me.usecnt) - res = -1; - ast_mutex_unlock(&me.lock); return res; } -int load_module(void) +static int load_module(void *mod) { int res; - res=ast_register_translator(&g723tolin); + res=ast_register_translator(&g723tolin, mod); if (!res) - res=ast_register_translator(&lintog723); + res=ast_register_translator(&lintog723, mod); else ast_unregister_translator(&g723tolin); return res; } -const char *description(void) +static const char *description(void) { #ifdef ANNEX_B return "Annex B (floating point) G.723.1/PCM16 Codec Translator"; @@ -336,12 +328,9 @@ const char *description(void) } -int usecount(void) -{ - return me.usecnt; -} - -const char *key(void) +static const char *key(void) { return ASTERISK_GPL_KEY; } + +STD_MOD(MOD_1, reload, NULL, NULL); -- cgit v1.2.3