From 751d7a5a49e67d0e13331c7a89c7eaa4724d1c87 Mon Sep 17 00:00:00 2001 From: George Joseph Date: Thu, 7 Apr 2016 10:49:43 -0600 Subject: alembic: Remove batch operations (and sqlite support) Because SQLite doesn't support full ALTER capabilities, alembic scripts require batch operations. However, that capability wasn't available until 0.7.0 which some distributions haven't reached yet. Therefore, the batch operations introduced in commit 86d6e44cc (review 2319) have been reverted and SQLite is unsupported again, for now anyway. Tested the full upgrade and downgrade on MySQL/Mariadb and Postgresql. ASTERISK-25890 #close Reported-by: Harley Peters Change-Id: I82eba5456736320256f6775f5b0b40133f4d1c80 --- .../e96a0b8071c_increase_pjsip_column_size.py | 30 +++++++++------------- 1 file changed, 12 insertions(+), 18 deletions(-) (limited to 'contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py') diff --git a/contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py b/contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py index f25c2987e..9c00c012e 100644 --- a/contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py +++ b/contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py @@ -15,28 +15,22 @@ import sqlalchemy as sa def upgrade(): - with op.batch_alter_table('ps_globals') as batch_op: - batch_op.alter_column('user_agent', type_=sa.String(255)) + op.alter_column('ps_globals', 'user_agent', type_=sa.String(255)) - with op.batch_alter_table('ps_contacts') as batch_op: - batch_op.alter_column('id', type_=sa.String(255)) - batch_op.alter_column('uri', type_=sa.String(255)) - batch_op.alter_column('user_agent', type_=sa.String(255)) + op.alter_column('ps_contacts', 'id', type_=sa.String(255)) + op.alter_column('ps_contacts', 'uri', type_=sa.String(255)) + op.alter_column('ps_contacts', 'user_agent', type_=sa.String(255)) - with op.batch_alter_table('ps_registrations') as batch_op: - batch_op.alter_column('client_uri', type_=sa.String(255)) - batch_op.alter_column('server_uri', type_=sa.String(255)) + op.alter_column('ps_registrations', 'client_uri', type_=sa.String(255)) + op.alter_column('ps_registrations', 'server_uri', type_=sa.String(255)) def downgrade(): - with op.batch_alter_table('ps_globals') as batch_op: - batch_op.alter_column('user_agent', type_=sa.String(40)) + op.alter_column('ps_globals', 'user_agent', type_=sa.String(40)) - with op.batch_alter_table('ps_contacts') as batch_op: - batch_op.alter_column('id', type_=sa.String(40)) - batch_op.alter_column('uri', type_=sa.String(40)) - batch_op.alter_column('user_agent', type_=sa.String(40)) + op.alter_column('ps_contacts', 'id', type_=sa.String(40)) + op.alter_column('ps_contacts', 'uri', type_=sa.String(40)) + op.alter_column('ps_contacts', 'user_agent', type_=sa.String(40)) - with op.batch_alter_table('ps_registrations') as batch_op: - batch_op.alter_column('client_uri', type_=sa.String(40)) - batch_op.alter_column('server_uri', type_=sa.String(40)) + op.alter_column('ps_registrations', 'client_uri', type_=sa.String(40)) + op.alter_column('ps_registrations', 'server_uri', type_=sa.String(40)) -- cgit v1.2.3