From 104a8047a53b538b76d7befaf1c95eea9ad5114e Mon Sep 17 00:00:00 2001 From: Kevin Harwell Date: Fri, 4 Aug 2017 16:47:30 -0500 Subject: res_pjsip_session/_sdp_rtp: Handling of 'msid' is incorrect Currently, the handling of the msid attribute is not quite right. According to the spec the msid's between the offer/answer are not dependent upon one another. Meaning the same msid's given in an offer do not have to be returned in the answer for a given stream. And they probably shouldn't be (copied/reused) since this can potentially cause some browser side confusion. This patch generates new msids when both an offer and answer are sent from Asterisk. However, Asterisk does reuse the original msid it sent out for a reinvite. Also audio+video streams are paired together by sharing the same stream id, but a different track id. ASTERISK-27179 #close Change-Id: Ifaec06dc7e65ad841633a24ebec8c8a9302d6643 --- include/asterisk/res_pjsip_session.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'include') diff --git a/include/asterisk/res_pjsip_session.h b/include/asterisk/res_pjsip_session.h index caf10db11..5f49c8237 100644 --- a/include/asterisk/res_pjsip_session.h +++ b/include/asterisk/res_pjsip_session.h @@ -105,8 +105,10 @@ struct ast_sip_session_media { int bundle_group; /*! \brief Whether this stream is currently bundled or not */ unsigned int bundled; - /*! \brief RTP/Media streams association identifier */ - char *msid; + /*! \brief Media stream label */ + char mslabel[AST_UUID_STR_LEN]; + /*! \brief Track label */ + char label[AST_UUID_STR_LEN]; }; /*! -- cgit v1.2.3