From c30170d9a22255e35606a8c506e398f817a5c15c Mon Sep 17 00:00:00 2001 From: Mark Michelson Date: Fri, 18 Oct 2013 18:44:21 +0000 Subject: Resolve some memory leaks due to incorrect for loop / ao2 ref usage. A common idiom in Asterisk is to due something like: for (ao2_obj = list_beginning; ao2_obj = next_item; ao2_ref(ao2_obj, -1)) { ...do stuff... } This is nice because it automatically takes care of the object references for you. However, there is a pitfall here. If a break statement is in the for loop, then the current reference is not cleaned up. In some cases, this is on purpose, but in others there is a leak. This commit fixes the leak cases. ........ Merged revisions 401248 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@401249 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/manager.c | 1 + 1 file changed, 1 insertion(+) (limited to 'main/manager.c') diff --git a/main/manager.c b/main/manager.c index f3e883407..a531feb80 100644 --- a/main/manager.c +++ b/main/manager.c @@ -3932,6 +3932,7 @@ static int action_status(struct mansession *s, const struct message *m) ast_free(built); if (!all) { + ao2_ref(msg, -1); break; } } -- cgit v1.2.3