From 11348736af2097be6ca9d99f160ead3e85e44ec2 Mon Sep 17 00:00:00 2001 From: Mark Michelson Date: Fri, 18 May 2012 17:54:07 +0000 Subject: Address MISSING_BREAK static analysis reports some more. This addresses core findings 4 and 6. Moises Silva helped me by stating that a break could be safely added to the case where it is added in chan_dahdi.c In say.c, I have added a comment indicating that static analysis complains but that it is currently unknown if this is correct. This fixes all core findings of this type. (closes issue ASTERISK-19662) reported by Matthew Jordan ........ Merged revisions 367027 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 367028 from http://svn.asterisk.org/svn/asterisk/branches/10 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@367029 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/say.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'main') diff --git a/main/say.c b/main/say.c index f4db3e0f0..9d6d4b16c 100644 --- a/main/say.c +++ b/main/say.c @@ -6127,6 +6127,9 @@ int ast_say_date_with_format_zh(struct ast_channel *chan, time_t t, const char * if (tm.tm_hour < 10) { res = wait_file(chan, ints, "digits/0", lang); } + /* XXX Static analysis warns of no break here. No idea if this is + * correct or not + */ case 'k': /* 24-Hour */ if (!(tm.tm_hour % 10) || tm.tm_hour < 10) { -- cgit v1.2.3