From 323c0927ac63ce1c13133961bd46abbf6d265a18 Mon Sep 17 00:00:00 2001 From: Scott Griepentrog Date: Fri, 6 Feb 2015 21:26:12 +0000 Subject: various: cleanup issues found during leak hunt In this collection of small patches to prevent Valgrind errors are: fixes for reference leaks in config hooks, evaluating a parameter beyond bounds, and accessing a structure after a lock where it could have been already free'd. Review: https://reviewboard.asterisk.org/r/4407/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@431583 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/config.c | 4 ++++ main/utils.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'main') diff --git a/main/config.c b/main/config.c index 0aa6bbefc..7e5141398 100644 --- a/main/config.c +++ b/main/config.c @@ -3821,6 +3821,9 @@ static void config_shutdown(void) AST_LIST_UNLOCK(&cfmtime_head); ast_cli_unregister_multiple(cli_config, ARRAY_LEN(cli_config)); + + ao2_cleanup(cfg_hooks); + cfg_hooks = NULL; } int register_config_cli(void) @@ -3909,5 +3912,6 @@ int ast_config_hook_register(const char *name, hook->module = ast_strdup(module); ao2_link(cfg_hooks, hook); + ao2_ref(hook, -1); return 0; } diff --git a/main/utils.c b/main/utils.c index 7032631f8..578a01e26 100644 --- a/main/utils.c +++ b/main/utils.c @@ -1856,7 +1856,7 @@ void ast_join_delim(char *s, size_t len, const char * const w[], unsigned int si /* Join words into a string */ if (!s) return; - for (x = 0; ofs < len && w[x] && x < size; x++) { + for (x = 0; ofs < len && x < size && w[x] ; x++) { if (x > 0) s[ofs++] = delim; for (src = w[x]; *src && ofs < len; src++) -- cgit v1.2.3