From b9f4bb59887bd5520b88505acfcc2f4eff0e7e66 Mon Sep 17 00:00:00 2001 From: Corey Farrell Date: Sat, 11 Nov 2017 11:09:29 -0500 Subject: menuselect: Remove ineffective weak attribute detection. menuselect detects compiler support for multiple styles of weak functions. This is a remnant from 2013 when OPTIONAL_API required weak functions. It is no longer correct for menuselect to switch dependencies from optional to required based on lack of weak function support. Note an issue remains - dependencies should switch from optional to required based on OPTIONAL_API being enabled or disabled. I don't think this is possible. menuselect needs to know at startup if OPTIONAL_API is enabled or disabled, so the only way to fix this is to remove OPTIONAL_API from menuselect and create a configure option. I've left the code that switches in place but it's preprocessed out. Additionally removed: - WEAKREF variable from Asterisk makeopts.in. - Related disabled code from test_utils. - Pointless AC_REVISION call from menuselect/configure.ac. Change-Id: Ifa702e5f98eb45f338b2f131a93354632a8fb389 --- makeopts.in | 1 - 1 file changed, 1 deletion(-) (limited to 'makeopts.in') diff --git a/makeopts.in b/makeopts.in index 1d31c29f9..43a472869 100644 --- a/makeopts.in +++ b/makeopts.in @@ -73,7 +73,6 @@ CONFIG_LDFLAGS=@CONFIG_LDFLAGS@ CONFIG_SIGNED_CHAR=@CONFIG_SIGNED_CHAR@ GNU_LD=@GNU_LD@ -WEAKREF=@PBX_WEAKREF@ HAVE_DYNAMIC_LIST=@PBX_DYNAMIC_LIST@ prefix = @prefix@ -- cgit v1.2.3