From 5997ec7c9e70f3b12afb948c421355fb87aed44e Mon Sep 17 00:00:00 2001 From: Alexei Gradinari Date: Tue, 19 Jul 2016 16:22:39 -0400 Subject: res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice. This patch removed call of pjsip_tx_data_dec_ref in send_notify if send_request failed. The pjsip_dlg_send_request deletes the message on error by itself. It seems this patch fixes next issues: ASTERISK-26199 ASTERISK-26166 ASTERISK-26174 Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a --- res/res_pjsip_pubsub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'res/res_pjsip_pubsub.c') diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c index f0e921cb8..3ac3f342f 100644 --- a/res/res_pjsip_pubsub.c +++ b/res/res_pjsip_pubsub.c @@ -2271,7 +2271,7 @@ static int send_notify(struct sip_subscription_tree *sub_tree, unsigned int forc } if (sip_subscription_send_request(sub_tree, tdata)) { - pjsip_tx_data_dec_ref(tdata); + /* do not call pjsip_tx_data_dec_ref(tdata). The pjsip_dlg_send_request deletes the message on error */ return -1; } -- cgit v1.2.3