From 2ebe811d80a2ea494260134315efd37fa4ff6cbb Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Sun, 8 Feb 2015 17:24:22 +0000 Subject: res/res_pjsip_sdp_rtp: Fix leak of local ICE candidates when applying to SDP When an SDP is created for an outgoing request/response, the ICE candidates obtained from the RTP instance are currently leaked. This causes the ao2 container that holds the candidates to never properly be reclaimed when the RTP instance is destroyed. This patch properly decrements the ICE candidates' container if it is successfully obtained. ASTERISK-24769 #close Reported by: Matt Jordan ........ Merged revisions 431600 from http://svn.asterisk.org/svn/asterisk/branches/13 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@431601 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- res/res_pjsip_sdp_rtp.c | 1 + 1 file changed, 1 insertion(+) (limited to 'res/res_pjsip_sdp_rtp.c') diff --git a/res/res_pjsip_sdp_rtp.c b/res/res_pjsip_sdp_rtp.c index bc8c748eb..4cac53731 100644 --- a/res/res_pjsip_sdp_rtp.c +++ b/res/res_pjsip_sdp_rtp.c @@ -396,6 +396,7 @@ static void add_ice_to_stream(struct ast_sip_session *session, struct ast_sip_se } ao2_iterator_destroy(&it_candidates); + ao2_ref(candidates, -1); } /*! \brief Function which processes ICE attributes in an audio stream */ -- cgit v1.2.3