From 9b3f6d26bda73046a72879290e0a58f1b69e654f Mon Sep 17 00:00:00 2001 From: George Joseph Date: Tue, 5 Sep 2017 04:23:04 -0600 Subject: res_pjsip_t38: Make t38_reinvite_response_cb tolerant of NULL channel t38_reinvite_response_cb can get called by res_pjsip_session's session_inv_on_tsx_state_changed in situations where session->channel is NULL. If it is, the ast_log warning segfaults because it tries to get the channel name from a NULL channel. * Check session->channel and print "unknown channel" when it's NULL. ASTERISK-27236 Reported by: Ross Beer Change-Id: I4326e288d36327f6c79ab52226d54905cdc87dc7 --- res/res_pjsip_t38.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'res/res_pjsip_t38.c') diff --git a/res/res_pjsip_t38.c b/res/res_pjsip_t38.c index 27eff424a..ce914a1e8 100644 --- a/res/res_pjsip_t38.c +++ b/res/res_pjsip_t38.c @@ -302,9 +302,9 @@ static int t38_reinvite_response_cb(struct ast_sip_session *session, pjsip_rx_da } state = t38_state_get_or_alloc(session); - if (!state) { + if (!session->channel || !state) { ast_log(LOG_WARNING, "Received response to T.38 re-invite on '%s' but state unavailable\n", - ast_channel_name(session->channel)); + session->channel ? ast_channel_name(session->channel) : "unknown channel"); return 0; } -- cgit v1.2.3