From a48d3e4d31c8060856d785fca00c5213d5e012bc Mon Sep 17 00:00:00 2001 From: Torrey Searle Date: Tue, 27 Jun 2017 17:46:43 +0200 Subject: res/res_pjsip_t38: fix incorrect increment of media_count The T38 sdp callback incorrectly has a side effect of incrementing the media_count. This can lead to core dumps. Change-Id: I7bb2f4987de4046ec52cfc34e5ea0662dae32af8 --- res/res_pjsip_t38.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'res/res_pjsip_t38.c') diff --git a/res/res_pjsip_t38.c b/res/res_pjsip_t38.c index bb1641a44..6019412b0 100644 --- a/res/res_pjsip_t38.c +++ b/res/res_pjsip_t38.c @@ -276,7 +276,7 @@ static int t38_reinvite_sdp_cb(struct ast_sip_session *session, pjmedia_sdp_sess /* Move the image media stream to the front and have it as the only stream, pjmedia will fill in * dummy streams for the rest */ - for (stream = 0; stream < sdp->media_count++; ++stream) { + for (stream = 0; stream < sdp->media_count; ++stream) { if (!pj_strcmp2(&sdp->media[stream]->desc.media, "image")) { sdp->media[0] = sdp->media[stream]; sdp->media_count = 1; -- cgit v1.2.3