From bb0b60619daddb1448e980f9067780bcd6ca5e35 Mon Sep 17 00:00:00 2001 From: Richard Mudgett Date: Mon, 30 Nov 2015 14:22:55 -0600 Subject: res_sorcery_memory_cache.c: Fix off nominal ref leak. Change-Id: If83d63cf11cbc6df9b15251848b01feb570ade49 --- res/res_sorcery_memory_cache.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'res/res_sorcery_memory_cache.c') diff --git a/res/res_sorcery_memory_cache.c b/res/res_sorcery_memory_cache.c index 0ce0e33a1..58aaada41 100644 --- a/res/res_sorcery_memory_cache.c +++ b/res/res_sorcery_memory_cache.c @@ -848,13 +848,16 @@ static void *sorcery_memory_cache_retrieve_id(const struct ast_sorcery *sorcery, if (cached->stale_update_sched_id == -1) { struct stale_update_task_data *task_data; - task_data = stale_update_task_data_alloc((struct ast_sorcery *)sorcery, cache, - type, cached->object); + task_data = stale_update_task_data_alloc((struct ast_sorcery *) sorcery, + cache, type, cached->object); if (task_data) { ast_debug(1, "Cached sorcery object type '%s' ID '%s' is stale. Refreshing\n", type, id); - cached->stale_update_sched_id = ast_sched_add(sched, 1, stale_item_update, task_data); - } else { + cached->stale_update_sched_id = ast_sched_add(sched, 1, + stale_item_update, task_data); + } + if (cached->stale_update_sched_id < 0) { + ao2_cleanup(task_data); ast_log(LOG_ERROR, "Unable to update stale cached object type '%s', ID '%s'.\n", type, id); } -- cgit v1.2.3