Array-style echo canceller updates first appeared in Zaptel, because HPEC only supports that mode. However, when the function for doing array-style updates was written, the argument names were reversed. In Zaptel this did no harm, because HPEC was the only module that used array-style updates.

When DAHDI was created, non-array-style updates were removed, and the existing modules were converted to using array-style updates. Unfortunately the new code was written based on the argument names, which were incorrect. This caused all the echo cancellers to be broken (except HPEC, although we did not know that at the time), and it was corrected by reversing the order of the arguments passed when the array-style update function was called (leading to a confusing mismatch). This fixed all the non-HPEC modules, but left HPEC broken, which was just discovered.

This commit corrects all these problems, so that the argument names and the data passed actually make sense, and all the modules work properly.



git-svn-id: http://svn.asterisk.org/svn/dahdi/linux/trunk@5936 a0bf4364-ded3-4de4-8d8a-66a801d63aff

1 files changed, 1 insertions, 1 deletions

diff --git a/include/dahdi/kernel.h b/include/dahdi/kernel.h
index 0fccfea..ef304d9 100644
--- a/include/dahdi/kernel.h
+++ b/include/dahdi/kernel.h
@@ -361,7 +361,7 @@ struct dahdi_echocan {
 	struct module *owner;
 	int (*echo_can_create)(struct dahdi_echocanparams *ecp, struct dahdi_echocanparam *p, struct echo_can_state **ec);
 	void (*echo_can_free)(struct echo_can_state *ec);
-	void (*echo_can_array_update)(struct echo_can_state *ec, short *iref, short *isig);
+	void (*echo_can_array_update)(struct echo_can_state *ec, short *isig, short *iref);
 	int (*echo_can_traintap)(struct echo_can_state *ec, int pos, short val);
 };