From 52e3732076ffbd5ab2186148bea303bbd01c6fc6 Mon Sep 17 00:00:00 2001 From: Tzafrir Cohen Date: Thu, 9 Feb 2012 15:25:03 +0000 Subject: code cleanup: remove unused debug_printk() The dahdi_echocan_* modules had an unused debug_printk() macro. Remove them because: * They were unused * There were multiple definitions * They were unsafe. Someone doing an if(foo) debug_printk(...); else do_something(); may be surprised ;-) * They used 'debug' as a debug level, while the rest of DAHDI debug macros treat it as a bit-field. Leave only a single definition in wcte12xp/base.c which is safe. Signed-off-by: Oron Peled Acked-by: Tzafrir Cohen git-svn-id: http://svn.asterisk.org/svn/dahdi/linux/trunk@10459 a0bf4364-ded3-4de4-8d8a-66a801d63aff --- drivers/dahdi/dahdi_echocan_jpah.c | 2 -- drivers/dahdi/dahdi_echocan_kb1.c | 2 -- drivers/dahdi/dahdi_echocan_mg2.c | 2 -- drivers/dahdi/dahdi_echocan_sec.c | 2 -- drivers/dahdi/dahdi_echocan_sec2.c | 2 -- drivers/dahdi/hpec/dahdi_echocan_hpec.c | 2 -- 6 files changed, 12 deletions(-) diff --git a/drivers/dahdi/dahdi_echocan_jpah.c b/drivers/dahdi/dahdi_echocan_jpah.c index d9687ca..541e238 100644 --- a/drivers/dahdi/dahdi_echocan_jpah.c +++ b/drivers/dahdi/dahdi_echocan_jpah.c @@ -38,8 +38,6 @@ static int debug; -#define debug_printk(level, fmt, args...) if (debug >= level) printk("%s (%s): " fmt, THIS_MODULE->name, __FUNCTION__, ## args) - static int echo_can_create(struct dahdi_chan *chan, struct dahdi_echocanparams *ecp, struct dahdi_echocanparam *p, struct dahdi_echocan_state **ec); static void echo_can_free(struct dahdi_chan *chan, struct dahdi_echocan_state *ec); diff --git a/drivers/dahdi/dahdi_echocan_kb1.c b/drivers/dahdi/dahdi_echocan_kb1.c index 6b7dbe8..e0941bf 100644 --- a/drivers/dahdi/dahdi_echocan_kb1.c +++ b/drivers/dahdi/dahdi_echocan_kb1.c @@ -44,8 +44,6 @@ static int debug; static int aggressive; -#define debug_printk(level, fmt, args...) if (debug >= level) printk(KERN_DEBUG "%s (%s): " fmt, THIS_MODULE->name, __FUNCTION__, ## args) - /* Uncomment to provide summary statistics for overall echo can performance every 4000 samples */ /* #define MEC2_STATS 4000 */ diff --git a/drivers/dahdi/dahdi_echocan_mg2.c b/drivers/dahdi/dahdi_echocan_mg2.c index 8ea3f78..3703f00 100644 --- a/drivers/dahdi/dahdi_echocan_mg2.c +++ b/drivers/dahdi/dahdi_echocan_mg2.c @@ -44,8 +44,6 @@ static int debug; static int aggressive; -#define debug_printk(level, fmt, args...) if (debug >= level) printk("%s (%s): " fmt, THIS_MODULE->name, __FUNCTION__, ## args) - #define ABS(a) abs(a!=-32768?a:-32767) #define RESTORE_COEFFS {\ diff --git a/drivers/dahdi/dahdi_echocan_sec.c b/drivers/dahdi/dahdi_echocan_sec.c index b5b6603..84a2df6 100644 --- a/drivers/dahdi/dahdi_echocan_sec.c +++ b/drivers/dahdi/dahdi_echocan_sec.c @@ -48,8 +48,6 @@ static int debug; -#define debug_printk(level, fmt, args...) if (debug >= level) printk(KERN_DEBUG "%s (%s): " fmt, THIS_MODULE->name, __FUNCTION__, ## args) - #include "arith.h" #ifndef NULL diff --git a/drivers/dahdi/dahdi_echocan_sec2.c b/drivers/dahdi/dahdi_echocan_sec2.c index 8750c85..da5a286 100644 --- a/drivers/dahdi/dahdi_echocan_sec2.c +++ b/drivers/dahdi/dahdi_echocan_sec2.c @@ -47,8 +47,6 @@ static int debug; -#define debug_printk(level, fmt, args...) if (debug >= level) printk(KERN_DEBUG "%s (%s): " fmt, THIS_MODULE->name, __FUNCTION__, ## args) - #include "fir.h" #ifndef NULL diff --git a/drivers/dahdi/hpec/dahdi_echocan_hpec.c b/drivers/dahdi/hpec/dahdi_echocan_hpec.c index 4559909..7d898a5 100644 --- a/drivers/dahdi/hpec/dahdi_echocan_hpec.c +++ b/drivers/dahdi/hpec/dahdi_echocan_hpec.c @@ -31,8 +31,6 @@ static int debug; -#define debug_printk(level, fmt, args...) if (debug >= level) printk(KERN_DEBUG "%s (%s): " fmt, THIS_MODULE->name, __FUNCTION__, ## args) - #include "hpec_user.h" #include "hpec.h" -- cgit v1.2.3