From 0e130bb977986dca79b4fad787e640525e7283eb Mon Sep 17 00:00:00 2001 From: Tzafrir Cohen Date: Mon, 7 Nov 2011 17:48:00 +0000 Subject: Extra debugging aids and messages * Added dahdi_dev_dbg() macro to print when we don't (yet) have a span number. * Added a new debug category: DAHDI_DBG_ASSIGN * Made sure error return code paths prints helpfull messages * Promote error messages from INFO to NOTICE * Change some errno values from EINVAL to EFAULT (internal errors not caused by user input) Signed-off-by: Oron Peled Acked-by Tzafrir Cohen Acked-by: Shaun Ruffell git-svn-id: http://svn.asterisk.org/svn/dahdi/linux/trunk@10328 a0bf4364-ded3-4de4-8d8a-66a801d63aff --- drivers/dahdi/dahdi-sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'drivers/dahdi/dahdi-sysfs.c') diff --git a/drivers/dahdi/dahdi-sysfs.c b/drivers/dahdi/dahdi-sysfs.c index 5dbd539..a03aba8 100644 --- a/drivers/dahdi/dahdi-sysfs.c +++ b/drivers/dahdi/dahdi-sysfs.c @@ -590,8 +590,10 @@ dahdi_device_assign_span(struct device *dev, struct device_attribute *attr, ret = sscanf(buf, "%u:%u:%u", &local_span_number, &desired_spanno, &desired_basechanno); - if (ret != 3) + if (ret != 3) { + dev_notice(dev, "badly formatted input (should be ::)\n"); return -EINVAL; + } if (desired_spanno && !desired_basechanno) { dev_notice(dev, "Must set span number AND base chan number\n"); -- cgit v1.2.3