From 8cc8da74f224d70b67cdb585e452f92c86b9ca94 Mon Sep 17 00:00:00 2001 From: Shaun Ruffell Date: Mon, 15 Aug 2011 21:55:49 +0000 Subject: wctc4xxp: Fix lock imbalance in wctc4xxp_watchdog. r10082 "wctc4xxp: Cleanup in-flight commands when halting due to hardware error." introduced a lock imblance on the error path where the cmd_list_lock would be unlocked twice when the board is halted due to a hardware error. Thanks sparse. Signed-off-by: Shaun Ruffell Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=10138 git-svn-id: http://svn.asterisk.org/svn/dahdi/linux/branches/2.5@10139 a0bf4364-ded3-4de4-8d8a-66a801d63aff --- drivers/dahdi/wctc4xxp/base.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/dahdi/wctc4xxp') diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index d1e3db9..35d24a0 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -3321,6 +3321,7 @@ wctc4xxp_watchdog(unsigned long data) "Board malfunctioning. " \ "Halting operation.\n"); reschedule_timer = 0; + spin_lock(&wc->cmd_list_lock); break; } /* ERROR: We've retried the command and -- cgit v1.2.3