From df4cdd780b279caba38e7267be57ed4182237921 Mon Sep 17 00:00:00 2001 From: Guido Günther Date: Thu, 19 Feb 2015 12:50:55 +0100 Subject: Don't use basestring to work toward Python3 support --- gbp/deb/source.py | 4 +++- gbp/git/args.py | 3 ++- gbp/git/modifier.py | 3 ++- gbp/git/repository.py | 11 ++++++----- 4 files changed, 13 insertions(+), 8 deletions(-) (limited to 'gbp') diff --git a/gbp/deb/source.py b/gbp/deb/source.py index 847df55..e523fd5 100644 --- a/gbp/deb/source.py +++ b/gbp/deb/source.py @@ -20,6 +20,8 @@ import os from gbp.deb.format import DebianSourceFormat from gbp.deb.changelog import ChangeLog +import six + class FileVfs(object): def __init__(self, dir): """ @@ -51,7 +53,7 @@ class DebianSource(object): """ self._changelog = None - if isinstance(vfs, basestring): + if isinstance(vfs, six.string_types): self._vfs = FileVfs(vfs) else: self._vfs = vfs diff --git a/gbp/git/args.py b/gbp/git/args.py index f9fc64d..6f3dfd0 100644 --- a/gbp/git/args.py +++ b/gbp/git/args.py @@ -18,6 +18,7 @@ Git command argument handling helpers """ +import six import collections class GitArgs(object): @@ -55,7 +56,7 @@ class GitArgs(object): Add arguments to argument list """ for arg in args: - if isinstance(arg, basestring): + if isinstance(arg, six.string_types): self._args.append(arg) elif isinstance(arg, collections.Iterable): for i in iter(arg): diff --git a/gbp/git/modifier.py b/gbp/git/modifier.py index 5878681..7aede7a 100644 --- a/gbp/git/modifier.py +++ b/gbp/git/modifier.py @@ -20,6 +20,7 @@ Someone who modifiers something in git like committing changes or authoring a patch """ +import six import calendar, datetime from gbp.git.errors import GitError @@ -59,7 +60,7 @@ class GitModifier(object): self._date = None tz = GitTz(0) - if isinstance(date, basestring): + if isinstance(date, six.string_types): timestamp, offset = date.split() offset_h = int(offset[:-2]) offset_m = int(offset[-2:]) diff --git a/gbp/git/repository.py b/gbp/git/repository.py index c261e40..797c8c0 100644 --- a/gbp/git/repository.py +++ b/gbp/git/repository.py @@ -16,6 +16,7 @@ # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA """A Git repository""" +import six import subprocess import os.path import re @@ -39,7 +40,7 @@ class GitRemote(object): def __init__(self, name, fetch_url, push_urls): self._name = name self._fetch_url = fetch_url - if isinstance(push_urls, basestring): + if isinstance(push_urls, six.string_types): self._push_urls = [push_urls] else: self._push_urls = [url for url in push_urls] @@ -1245,7 +1246,7 @@ class GitRepository(object): """ extra_env = {} - if isinstance(paths, basestring): + if isinstance(paths, six.string_types): paths = [ paths ] args = [ '-f' ] if force else [] @@ -1267,7 +1268,7 @@ class GitRepository(object): @param verbose: be verbose @type verbose: C{bool} """ - if isinstance(paths, basestring): + if isinstance(paths, six.string_types): paths = [ paths ] args = [] if verbose else ['--quiet'] @@ -1368,7 +1369,7 @@ class GitRepository(object): @param author_info: authorship information @type author_info: L{GitModifier} """ - if isinstance(files, basestring): + if isinstance(files, six.string_types): files = [ files ] self._commit(msg=msg, args=files, author_info=author_info) @@ -1497,7 +1498,7 @@ class GitRepository(object): args.add(until) args.add_cond(options, options) args.add("--") - if isinstance(paths, basestring): + if isinstance(paths, six.string_types): paths = [ paths ] args.add_cond(paths, paths) -- cgit v1.2.3