diff options
| author | Benny Prijono <bennylp@teluu.com> | 2006-06-22 18:44:11 +0000 |
|---|---|---|
| committer | Benny Prijono <bennylp@teluu.com> | 2006-06-22 18:44:11 +0000 |
| commit | 9f837639562ef282625d862ec223ee585038147a (patch) | |
| tree | 53d6c4e094496d9fbece2169fc7873fc8648dcef /pjmedia/src | |
| parent | 9d93457bad88472dfd53fa844758bc5acc3a10ef (diff) | |
Fixed RTCP statistic returning fraction lost instead of total lost
git-svn-id: http://svn.pjsip.org/repos/pjproject/trunk@537 74dad513-b988-da41-8d7b-12977e46ad98
Diffstat (limited to 'pjmedia/src')
| -rw-r--r-- | pjmedia/src/pjmedia/rtcp.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/pjmedia/src/pjmedia/rtcp.c b/pjmedia/src/pjmedia/rtcp.c index 7c5b8d5f..f96d818c 100644 --- a/pjmedia/src/pjmedia/rtcp.c +++ b/pjmedia/src/pjmedia/rtcp.c @@ -207,13 +207,19 @@ PJ_DEF(void) pjmedia_rtcp_rx_rtp(pjmedia_rtcp_session *sess, rtcp_init_seq(sess); } - if (seq_st.status.flag.dup) + if (seq_st.status.flag.dup) { sess->stat.rx.dup++; - if (seq_st.status.flag.outorder) + TRACE_((sess->name, "Duplicate packet detected")); + } + + if (seq_st.status.flag.outorder) { sess->stat.rx.reorder++; + TRACE_((sess->name, "Out-of-order packet detected")); + } if (seq_st.status.flag.bad) { sess->stat.rx.discard++; + TRACE_((sess->name, "Bad packet discarded")); return; } @@ -233,6 +239,7 @@ PJ_DEF(void) pjmedia_rtcp_rx_rtp(pjmedia_rtcp_session *sess, * outbound RTCP RR. */ sess->stat.rx.loss += (seq_st.diff - 1); + TRACE_((sess->name, "%d packet(s) lost", seq_st.diff - 1)); /* Update loss period stat */ if (sess->stat.rx.loss_period.count == 0 || @@ -541,10 +548,13 @@ PJ_DEF(void) pjmedia_rtcp_build_rtcp(pjmedia_rtcp_session *sess, /* Total lost. */ expected = pj_ntohl(rtcp_pkt->rr.last_seq) - sess->seq_ctrl.base_seq; + + /* This is bug: total lost already calculated on each incoming RTP! if (expected >= sess->received) sess->stat.rx.loss = expected - sess->received; else sess->stat.rx.loss = 0; + */ rtcp_pkt->rr.total_lost_2 = (sess->stat.rx.loss >> 16) & 0xFF; rtcp_pkt->rr.total_lost_1 = (sess->stat.rx.loss >> 8) & 0xFF; |