From 813db6d4094126dadf3c53ea346b08f04d223528 Mon Sep 17 00:00:00 2001 From: Benny Prijono Date: Tue, 8 Oct 2013 11:15:22 +0000 Subject: Re #1703 General bug fixes: fixed mutex not released on some error condition git-svn-id: http://svn.pjsip.org/repos/pjproject/trunk@4616 74dad513-b988-da41-8d7b-12977e46ad98 --- pjmedia/src/pjmedia/codec.c | 4 +++- pjmedia/src/pjmedia/vid_codec.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'pjmedia') diff --git a/pjmedia/src/pjmedia/codec.c b/pjmedia/src/pjmedia/codec.c index 3c647670..a79421e5 100644 --- a/pjmedia/src/pjmedia/codec.c +++ b/pjmedia/src/pjmedia/codec.c @@ -636,8 +636,10 @@ PJ_DEF(pj_status_t) pjmedia_codec_mgr_set_default_param( /* Update codec param */ p->param = pjmedia_codec_param_clone(pool, param); - if (!p->param) + if (!p->param) { + pj_mutex_unlock(mgr->mutex); return PJ_EINVAL; + } pj_mutex_unlock(mgr->mutex); diff --git a/pjmedia/src/pjmedia/vid_codec.c b/pjmedia/src/pjmedia/vid_codec.c index 93690a29..208c8579 100644 --- a/pjmedia/src/pjmedia/vid_codec.c +++ b/pjmedia/src/pjmedia/vid_codec.c @@ -722,8 +722,10 @@ PJ_DEF(pj_status_t) pjmedia_vid_codec_mgr_set_default_param( /* Update codec default param */ p->param = pjmedia_vid_codec_param_clone(pool, param); - if (!p->param) + if (!p->param) { + pj_mutex_unlock(mgr->mutex); return PJ_EINVAL; + } codec_desc->def_param = p; -- cgit v1.2.3