From 0ff610e8129c39872566c60efa832f95f371ad2e Mon Sep 17 00:00:00 2001
From: Aart Stuurman <aart.stuurman@copernica.com>
Date: Tue, 28 Jul 2015 11:41:38 +0200
Subject: removed value::attach() methods, because they were not in use, and
 were probably broken too

---
 include/value.h | 12 ------------
 zend/value.cpp  | 44 --------------------------------------------
 2 files changed, 56 deletions(-)

diff --git a/include/value.h b/include/value.h
index 3aad995..807ad42 100644
--- a/include/value.h
+++ b/include/value.h
@@ -1153,18 +1153,6 @@ protected:
      */
     struct _zval_struct *detach();
 
-    /**
-     *  Attach a different zval
-     *
-     *  This will first detach the current zval, and link the Value object to
-     *  a different zval. Versions exist to attach to a zval and to an entire
-     *  hash table
-     *
-     *  @param  val
-     */
-    void attach(struct _zval_struct *val);
-    void attach(struct _hashtable *hashtable);
-
     /**
      *  Set a certain property without running any checks (you must already know
      *  for sure that this is an array, and that the index is not yet in use)
diff --git a/zend/value.cpp b/zend/value.cpp
index 86b658c..e2d18f1 100644
--- a/zend/value.cpp
+++ b/zend/value.cpp
@@ -338,50 +338,6 @@ zval *Value::detach()
     return result;
 }
 
-/**
- *  Attach a different zval
- *
- *  This will first detach the current zval, and link the Value object to
- *  a different zval.
- *
- *  @param  val
- */
-void Value::attach(struct _zval_struct *val)
-{
-    // detach first
-    if (_val) detach();
-
-    // store the zval
-    _val = val;
-
-    // add one more reference
-    Z_ADDREF_P(_val);
-}
-
-/**
- *  Attach a different zval
- *
- *  This will first detach the current zval, and link the Value object to
- *  a new zval
- *
- *  @param  hashtable
- */
-void Value::attach(struct _hashtable *hashtable)
-{
-    // detach first
-    if (_val) detach();
-
-    // construct a new zval
-    MAKE_STD_ZVAL(_val);
-
-    // store pointer to the hashtable, and mark the zval as an array
-    Z_ARRVAL_P(_val) = hashtable;
-    Z_TYPE_P(_val) = IS_ARRAY;
-
-    // add a reference
-    Z_ADDREF_P(_val);
-}
-
 /**
  *  Retrieve the refcount
  *  @return int
-- 
cgit v1.2.3