From 578fc01d0e6ba0be7818ad2d2533aa3a2dde3ba4 Mon Sep 17 00:00:00 2001 From: Toon Schoenmakers Date: Fri, 21 Nov 2014 14:23:58 +0100 Subject: fixed value destructor, reference variables should not be unreferenced --- zend/value.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/zend/value.cpp b/zend/value.cpp index 544926a..b28096a 100644 --- a/zend/value.cpp +++ b/zend/value.cpp @@ -303,7 +303,13 @@ Value::~Value() // if there were two references or less, we're going to remove a reference // and only one reference will remain, the object will then impossible be // a reference - if (Z_REFCOUNT_P(_val) <= 2) Z_UNSET_ISREF_P(_val); + // + // This initially seemed to be a good idea, because reference-variables + // are hard to deal with, and a reference with only one or even zero variables + // pointing towards it seem silly, but this line of code caused objects only + // to be destructed when the script exits + // + // if (Z_REFCOUNT_P(_val) <= 2) Z_UNSET_ISREF_P(_val); // destruct the zval (this function will decrement the reference counter, // and only destruct if there are no other references left) -- cgit v1.2.3