From 6d7e0feaa709e518f527a00cb7b1ac675a8ce328 Mon Sep 17 00:00:00 2001 From: chipx86 Date: Fri, 27 Mar 2009 08:48:23 +0000 Subject: Patch by Raghu Kaippully to fix changesets with binary files in Perforce when using post-review. Reviewed at http://reviews.review-board.org/r/787/ Fixes bug #585 --- AUTHORS | 5 +++++ scripts/post-review | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 675325c..f68edfa 100644 --- a/AUTHORS +++ b/AUTHORS @@ -2,3 +2,8 @@ Lead Developers: * Christian Hammond * David Trowbridge + + +Contributors: + + * Raghu Kaippully diff --git a/scripts/post-review b/scripts/post-review index d2c1335..9f67c9c 100755 --- a/scripts/post-review +++ b/scripts/post-review @@ -1455,7 +1455,8 @@ class PerforceClient(SCMClient): # and the code below expects the outptu to start with # "Binary files " if len(dl) == 1 and \ - dl[0] == ('Files %s and %s differ'% (old_file, new_file)): + dl[0].startswith('Files %s and %s differ' % + (old_file, new_file)): dl = ['Binary files %s and %s differ'% (old_file, new_file)] if dl == [] or dl[0].startswith("Binary files "): -- cgit v1.2.3