From 975ef607f1fcb8c375b2cf52a05db4de9460a823 Mon Sep 17 00:00:00 2001 From: trowbrds Date: Sun, 26 Jul 2009 22:39:59 +0000 Subject: Perforce binary file diff corruption fix. When a binary file differed, post-review would miss printing a newline after "Binary Files differ", making the diff invalid for the subsequent file. This would cause that file's diff to be lost silently when parsed by reviewboard on the server side. Patch from Chris Trimble. Reviewed at http://reviews.review-board.org/r/915/ --- rbtools/postreview.py | 1 + 1 file changed, 1 insertion(+) diff --git a/rbtools/postreview.py b/rbtools/postreview.py index 9f50f2c..d5cda25 100755 --- a/rbtools/postreview.py +++ b/rbtools/postreview.py @@ -1665,6 +1665,7 @@ class PerforceClient(SCMClient): dl.insert(0, "==== %s#%s ==%s== %s ====\n" % \ (depot_path, base_revision, changetype_short, local_path)) + dl.append('\n') else: m = re.search(r'(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)', dl[1]) if m: -- cgit v1.2.3