From 2816c80e27f08ff715ac8f8ef4b77dc678fc606a Mon Sep 17 00:00:00 2001 From: Guido Günther Date: Thu, 19 Feb 2015 13:09:31 +0100 Subject: Use six.iteritems() and six.iterkeys() to work towards Python3 support Gbp-Dch: Ignore --- gbp/pkg/__init__.py | 4 +++- gbp/scripts/create_remote_repo.py | 5 ++++- tests/02_test_upstream_source_tar_unpack.py | 10 ++++++---- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/gbp/pkg/__init__.py b/gbp/pkg/__init__.py index 34f81cd..f3a81ae 100644 --- a/gbp/pkg/__init__.py +++ b/gbp/pkg/__init__.py @@ -21,6 +21,8 @@ import os import re import glob +import six + import gbp.command_wrappers as gbpc from gbp.errors import GbpError @@ -83,7 +85,7 @@ def parse_archive_filename(filename): base_name = ".".join(split[:-1]) (archive_fmt, compression) = (split[-1], None) else: - for (c, o) in compressor_opts.iteritems(): + for (c, o) in six.iteritems(compressor_opts): if o[1] == split[-1]: base_name = ".".join(split[:-1]) compression = c diff --git a/gbp/scripts/create_remote_repo.py b/gbp/scripts/create_remote_repo.py index 821f060..73bd270 100644 --- a/gbp/scripts/create_remote_repo.py +++ b/gbp/scripts/create_remote_repo.py @@ -27,6 +27,9 @@ import urlparse import subprocess import tty, termios import re + +import six + from gbp.deb.changelog import ChangeLog, NoChangeLogError from gbp.command_wrappers import (CommandExecFailed, GitCommand) from gbp.config import (GbpOptionParserDebian, GbpOptionGroup) @@ -68,7 +71,7 @@ def print_config(remote, branches): def sort_dict(d): """Return a sorted list of (key, value) tuples""" s = [] - for key in sorted(d.iterkeys()): + for key in sorted(six.iterkeys(d)): s.append((key, d[key])) return s diff --git a/tests/02_test_upstream_source_tar_unpack.py b/tests/02_test_upstream_source_tar_unpack.py index 163b26a..02b5043 100644 --- a/tests/02_test_upstream_source_tar_unpack.py +++ b/tests/02_test_upstream_source_tar_unpack.py @@ -8,6 +8,8 @@ import os import tarfile import unittest +import six + import gbp.pkg class TestUnpack(unittest.TestCase): @@ -46,7 +48,7 @@ class TestUnpack(unittest.TestCase): context.teardown() def test_upstream_source_type(self): - for (comp, archive) in self.archives.iteritems(): + for (comp, archive) in six.iteritems(self.archives): source = gbp.pkg.UpstreamSource(archive[0]) assert source.is_orig() == True assert source.is_dir() == False @@ -57,13 +59,13 @@ class TestUnpack(unittest.TestCase): assert type(source.unpacked) == str def test_upstream_source_unpack(self): - for (comp, archive) in self.archives.iteritems(): + for (comp, archive) in six.iteritems(self.archives): source = gbp.pkg.UpstreamSource(archive[0]) source.unpack(".") self._check_files(archive[1], comp) def test_upstream_source_unpack_no_filter(self): - for (comp, archive) in self.archives.iteritems(): + for (comp, archive) in six.iteritems(self.archives): source = gbp.pkg.UpstreamSource(archive[0]) source.unpack(".", []) self._check_files(archive[1], comp) @@ -71,7 +73,7 @@ class TestUnpack(unittest.TestCase): def test_upstream_source_unpack_filtered(self): exclude = "README" - for (comp, archive) in self.archives.iteritems(): + for (comp, archive) in six.iteritems(self.archives): source = gbp.pkg.UpstreamSource(archive[0]) source.unpack(".", [exclude]) archive[1].remove(exclude) -- cgit v1.2.3