diff options
| author | Jonathan Rose <jrose@digium.com> | 2013-10-25 17:41:38 +0000 |
|---|---|---|
| committer | Jonathan Rose <jrose@digium.com> | 2013-10-25 17:41:38 +0000 |
| commit | bb1568caa12dd10cbbe7ec84fcbdcfd0f3a2156c (patch) | |
| tree | 3e0ee4b296545345335009165b49373d48014e11 | |
| parent | e920fc0669ecbfccce2d4ea3fac0425be00d7b75 (diff) | |
PJSIP: Add log messages when requests are received for non-existent endpoints
(closes issue ASTERISK-22552)
Reported by: Rusty Newton
Review: https://reviewboard.asterisk.org/r/2934/
........
Merged revisions 401938 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@401939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
| -rw-r--r-- | res/res_pjsip/pjsip_distributor.c | 11 | ||||
| -rw-r--r-- | res/res_pjsip_endpoint_identifier_user.c | 2 |
2 files changed, 13 insertions, 0 deletions
diff --git a/res/res_pjsip/pjsip_distributor.c b/res/res_pjsip/pjsip_distributor.c index d7a92abde..9fd6250e8 100644 --- a/res/res_pjsip/pjsip_distributor.c +++ b/res/res_pjsip/pjsip_distributor.c @@ -232,6 +232,16 @@ struct ast_sip_endpoint *ast_sip_get_artificial_endpoint(void) return artificial_endpoint; } +static void log_unidentified_request(pjsip_rx_data *rdata) +{ + char from_buf[PJSIP_MAX_URL_SIZE]; + char callid_buf[PJSIP_MAX_URL_SIZE]; + pjsip_uri_print(PJSIP_URI_IN_FROMTO_HDR, rdata->msg_info.from->uri, from_buf, PJSIP_MAX_URL_SIZE); + ast_copy_pj_str(callid_buf, &rdata->msg_info.cid->id, PJSIP_MAX_URL_SIZE); + ast_log(LOG_NOTICE, "Request from '%s' failed for '%s:%d' (callid: %s) - No matching endpoint found\n", + from_buf, rdata->pkt_info.src_name, rdata->pkt_info.src_port, callid_buf); +} + static pj_bool_t endpoint_lookup(pjsip_rx_data *rdata) { struct ast_sip_endpoint *endpoint; @@ -262,6 +272,7 @@ static pj_bool_t endpoint_lookup(pjsip_rx_data *rdata) ast_copy_pj_str(name, &sip_from->user, sizeof(name)); } + log_unidentified_request(rdata); ast_sip_report_invalid_endpoint(name, rdata); } rdata->endpt_info.mod_data[endpoint_mod.id] = endpoint; diff --git a/res/res_pjsip_endpoint_identifier_user.c b/res/res_pjsip_endpoint_identifier_user.c index 29266febf..4b10bd388 100644 --- a/res/res_pjsip_endpoint_identifier_user.c +++ b/res/res_pjsip_endpoint_identifier_user.c @@ -102,6 +102,8 @@ done: return NULL; } ast_debug(3, "Retrieved endpoint %s\n", ast_sorcery_object_get_id(endpoint)); + } else { + ast_debug(3, "Could not identify endpoint by username '%s'\n", endpoint_name); } return endpoint; } |