summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Mudgett <rmudgett@digium.com>2013-09-12 23:42:23 +0000
committerRichard Mudgett <rmudgett@digium.com>2013-09-12 23:42:23 +0000
commitef53242700d15ecd7f86442ed0df240d958433d1 (patch)
tree263bf71ee40f3190cdcf20404c4e12ab12d7ef1d
parent94754227a6bd0258cc01ad62374867eff6ca7a6f (diff)
CLI bridge: Fix "bridge destroy <id>" and "bridge kick <id> <chan>" tab completion.
These two commands must deal with the live bridges container for tab completion and not the stasis cache. ........ Merged revisions 399021 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@399022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
-rw-r--r--main/bridge.c52
1 files changed, 45 insertions, 7 deletions
diff --git a/main/bridge.c b/main/bridge.c
index 64731df54..45820c3fa 100644
--- a/main/bridge.c
+++ b/main/bridge.c
@@ -4467,7 +4467,42 @@ static int bridge_sort_cmp(const void *obj_left, const void *obj_right, int flag
return cmp;
}
-static char *complete_bridge(const char *word, int state)
+struct bridge_complete {
+ /*! Nth match to return. */
+ int state;
+ /*! Which match currently on. */
+ int which;
+};
+
+static int complete_bridge_live_search(void *obj, void *arg, void *data, int flags)
+{
+ struct bridge_complete *search = data;
+
+ if (++search->which > search->state) {
+ return CMP_MATCH;
+ }
+ return 0;
+}
+
+static char *complete_bridge_live(const char *word, int state)
+{
+ char *ret;
+ struct ast_bridge *bridge;
+ struct bridge_complete search = {
+ .state = state,
+ };
+
+ bridge = ao2_callback_data(bridges, ast_strlen_zero(word) ? 0 : OBJ_PARTIAL_KEY,
+ complete_bridge_live_search, (char *) word, &search);
+ if (!bridge) {
+ return NULL;
+ }
+ ret = ast_strdup(bridge->uniqueid);
+ ao2_ref(bridge, -1);
+ return ret;
+}
+
+static char *complete_bridge_stasis(const char *word, int state)
{
char *ret = NULL;
int wordlen = strlen(word), which = 0;
@@ -4475,7 +4510,8 @@ static char *complete_bridge(const char *word, int state)
struct ao2_iterator iter;
struct stasis_message *msg;
- if (!(cached_bridges = stasis_cache_dump(ast_bridge_cache(), ast_bridge_snapshot_type()))) {
+ cached_bridges = stasis_cache_dump(ast_bridge_cache(), ast_bridge_snapshot_type());
+ if (!cached_bridges) {
return NULL;
}
@@ -4513,7 +4549,8 @@ static char *handle_bridge_show_all(struct ast_cli_entry *e, int cmd, struct ast
return NULL;
}
- if (!(cached_bridges = stasis_cache_dump(ast_bridge_cache(), ast_bridge_snapshot_type()))) {
+ cached_bridges = stasis_cache_dump(ast_bridge_cache(), ast_bridge_snapshot_type());
+ if (!cached_bridges) {
ast_cli(a->fd, "Failed to retrieve cached bridges\n");
return CLI_SUCCESS;
}
@@ -4545,7 +4582,8 @@ static int bridge_show_specific_print_channel(void *obj, void *arg, int flags)
RAII_VAR(struct stasis_message *, msg, NULL, ao2_cleanup);
struct ast_channel_snapshot *snapshot;
- if (!(msg = stasis_cache_get(ast_channel_cache(), ast_channel_snapshot_type(), uniqueid))) {
+ msg = stasis_cache_get(ast_channel_cache(), ast_channel_snapshot_type(), uniqueid);
+ if (!msg) {
return 0;
}
snapshot = stasis_message_data(msg);
@@ -4569,7 +4607,7 @@ static char *handle_bridge_show_specific(struct ast_cli_entry *e, int cmd, struc
return NULL;
case CLI_GENERATE:
if (a->pos == 2) {
- return complete_bridge(a->word, a->n);
+ return complete_bridge_stasis(a->word, a->n);
}
return NULL;
}
@@ -4607,7 +4645,7 @@ static char *handle_bridge_destroy_specific(struct ast_cli_entry *e, int cmd, st
return NULL;
case CLI_GENERATE:
if (a->pos == 2) {
- return complete_bridge(a->word, a->n);
+ return complete_bridge_live(a->word, a->n);
}
return NULL;
}
@@ -4670,7 +4708,7 @@ static char *handle_bridge_kick_channel(struct ast_cli_entry *e, int cmd, struct
return NULL;
case CLI_GENERATE:
if (a->pos == 2) {
- return complete_bridge(a->word, a->n);
+ return complete_bridge_live(a->word, a->n);
}
if (a->pos == 3) {
return complete_bridge_participant(a->argv[2], a->line, a->word, a->pos, a->n);