summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzuul <zuul@gerrit.asterisk.org>2017-02-16 07:08:29 -0600
committerGerrit Code Review <gerrit2@gerrit.digium.api>2017-02-16 07:08:29 -0600
commit3ed09e2822f9bcc4f79f22017fff1f7233dac170 (patch)
tree1a1ac0dfa568fa3eb7353db77f0aae799d67e2b7
parentca7fa7bbd2d54766f6b5911d7aa046cdcfd0dfe8 (diff)
parentce810a892b5f6605cdbb5586ce72c208714437ed (diff)
Merge "pjsip_distributor.c: Fix off-nominal tdata ref leak."
-rw-r--r--res/res_pjsip/pjsip_distributor.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/res/res_pjsip/pjsip_distributor.c b/res/res_pjsip/pjsip_distributor.c
index 741244586..eabfa4ba9 100644
--- a/res/res_pjsip/pjsip_distributor.c
+++ b/res/res_pjsip/pjsip_distributor.c
@@ -729,8 +729,7 @@ static pj_bool_t authenticate(pjsip_rx_data *rdata)
ao2_ref(unid, -1);
}
ast_sip_report_auth_success(endpoint, rdata);
- pjsip_tx_data_dec_ref(tdata);
- return PJ_FALSE;
+ break;
case AST_SIP_AUTHENTICATION_FAILED:
log_failed_request(rdata, "Failed to authenticate", 0, 0);
ast_sip_report_auth_failed_challenge_response(endpoint, rdata);
@@ -743,6 +742,7 @@ static pj_bool_t authenticate(pjsip_rx_data *rdata)
pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 500, NULL, NULL, NULL);
return PJ_TRUE;
}
+ pjsip_tx_data_dec_ref(tdata);
}
return PJ_FALSE;