diff options
author | Matt Jordan <mjordan@digium.com> | 2015-08-29 12:31:58 -0500 |
---|---|---|
committer | Gerrit Code Review <gerrit2@gerrit.digium.api> | 2015-08-29 12:31:59 -0500 |
commit | e23a01acbbef147824be26189d67b454663bf60c (patch) | |
tree | f7554591ec67499bf3ba179d30907ef120b55c99 | |
parent | fdc287ea3abd35eeb2fe7e32b26c044572926b92 (diff) | |
parent | fc4d4f53792b4867f963824868d1276b1120017f (diff) |
Merge "taskprocessor: Fix race condition between unreferencing and finding."
-rw-r--r-- | main/taskprocessor.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/main/taskprocessor.c b/main/taskprocessor.c index 1edbaa3ed..5c513ee66 100644 --- a/main/taskprocessor.c +++ b/main/taskprocessor.c @@ -691,15 +691,25 @@ void *ast_taskprocessor_unreference(struct ast_taskprocessor *tps) return NULL; } + /* To prevent another thread from finding and getting a reference to this + * taskprocessor we hold the singletons lock. If we didn't do this then + * they may acquire it and find that the listener has been shut down. + */ + ao2_lock(tps_singletons); + if (ao2_ref(tps, -1) > 3) { + ao2_unlock(tps_singletons); return NULL; } + /* If we're down to 3 references, then those must be: * 1. The reference we just got rid of * 2. The container * 3. The listener */ - ao2_unlink(tps_singletons, tps); + ao2_unlink_flags(tps_singletons, tps, OBJ_NOLOCK); + ao2_unlock(tps_singletons); + listener_shutdown(tps->listener); return NULL; } |