summaryrefslogtreecommitdiff
path: root/Makefile
diff options
context:
space:
mode:
authorGeorge Joseph <gjoseph@digium.com>2017-02-27 11:25:01 -0700
committerGeorge Joseph <gjoseph@digium.com>2017-02-27 11:55:41 -0700
commit3d2c11977850ea5f8e87e22e141e5a42dd28cabd (patch)
treeb250d70717e5eb6cc187487f3155ed1183e427ab /Makefile
parent9d3ab062cccc5d545648dd65beb817c37f439c2f (diff)
build: Warn if asterisk is installed in both 32 and 64 bit sys dirs
... and clean them both up on uninstall. We've fixed the issue where 'make install' was installing to /usr/lib on 64-bit systems that use /usr/lib64. Now we need to clean up the remnants in /usr/lib. * 'make install' now prints a warning if DESTDIR/ASTLIBDIR contains 'lib64' and libasterisk* shared libraries or modules are also found in DESTDIR/ASTLIBDIR with 'lib64' transformed to 'lib'. * 'make uninstall' ALWAYS cleans up both DESTDIR/ASTLIBDIR and DESTDIR/ASTLIBDIR with 'lib64' transformed to 'lib'. ASTERISK-26705 Change-Id: I6edddeb3c07a51e7c7ba7cac3c05e4bf3ec3f01f
Diffstat (limited to 'Makefile')
-rw-r--r--Makefile35
1 files changed, 35 insertions, 0 deletions
diff --git a/Makefile b/Makefile
index 687ab966f..0487abdd4 100644
--- a/Makefile
+++ b/Makefile
@@ -653,6 +653,37 @@ ifneq ($(LDCONFIG),)
fi
endif
+ifeq ($(and $(findstring 64,$(HOST_CPU)),$(findstring lib64,$(DESTDIR)$(ASTLIBDIR))),lib64)
+_oldlibdir = $(subst lib64,lib,$(DESTDIR)$(ASTLIBDIR))
+
+check-old-libdir:
+ @oldfiles=`find "$(_oldlibdir)" -name libasterisk* -print -quit -o \( -path *asterisk/modules/* -a -name *.so \) -print -quit` ;\
+ if [ "x$$oldfiles" != "x" ] ; then \
+ echo " WARNING WARNING WARNING" ;\
+ echo "" ;\
+ echo " Installation is to: " ;\
+ echo " $(DESTDIR)$(ASTLIBDIR)" ;\
+ echo " but there are asterisk shared libraries in: " ;\
+ echo " $(_oldlibdir)" ;\
+ echo " or" ;\
+ echo " $(_oldlibdir)/asterisk/modules" ;\
+ echo "" ;\
+ echo " It is unlikely that asterisk will start." ;\
+ echo "" ;\
+ echo " You should do one of the following..." ;\
+ echo " * Run 'make uninstall' to remove the incorrect libraries" ;\
+ echo " then run 'make install' again." ;\
+ echo " * Manually remove the libraries from" ;\
+ echo " $(_oldlibdir)" ;\
+ echo " and run 'ldconfig' to rebuild the linker cache." ;\
+ echo "" ;\
+ echo " WARNING WARNING WARNING" ;\
+ fi
+else
+check-old-libdir:
+
+endif
+
badshell:
ifneq ($(filter ~%,$(DESTDIR)),)
@echo "Your shell doesn't do ~ expansion when expected (specifically, when doing \"make install DESTDIR=~/path\")."
@@ -692,6 +723,7 @@ install: badshell bininstall datafiles
@echo " +-------------------------------------------+"
@$(MAKE) -s oldmodcheck
@$(MAKE) -s ld-cache-update
+ @$(MAKE) -s check-old-libdir
isntall: install
@@ -912,6 +944,7 @@ main-binuninstall:
_uninstall: $(SUBDIRS_UNINSTALL) main-binuninstall
rm -f "$(DESTDIR)$(ASTMODDIR)/"*
+ rm -f "$(subst lib64,lib,$(DESTDIR)$(ASTMODDIR))/"*
rm -f "$(DESTDIR)$(ASTSBINDIR)/astgenkey"
rm -f "$(DESTDIR)$(ASTSBINDIR)/autosupport"
rm -rf "$(DESTDIR)$(ASTHEADERDIR)"
@@ -944,6 +977,7 @@ uninstall: _uninstall
uninstall-all: _uninstall
rm -rf "$(DESTDIR)$(ASTMODDIR)"
+ rm -rf "$(subst lib64,lib,$(DESTDIR)$(ASTMODDIR))"
rm -rf "$(DESTDIR)$(ASTVARLIBDIR)"
rm -rf "$(DESTDIR)$(ASTDATADIR)"
rm -rf "$(DESTDIR)$(ASTSPOOLDIR)"
@@ -1058,6 +1092,7 @@ check-alembic: makeopts
.PHONY: basic-pbx
.PHONY: check-alembic
.PHONY: ld-cache-update
+.PHONY: check-old-libdir
.PHONY: $(SUBDIRS_INSTALL)
.PHONY: $(SUBDIRS_DIST_CLEAN)
.PHONY: $(SUBDIRS_CLEAN)