summaryrefslogtreecommitdiff
path: root/README-SERIOUSLY.bestpractices.txt
diff options
context:
space:
mode:
authorMichael L. Young <elgueromexicano@gmail.com>2013-10-28 14:59:16 +0000
committerMichael L. Young <elgueromexicano@gmail.com>2013-10-28 14:59:16 +0000
commit230141d677043f3cd9330c43291c5c2b35aa5bc8 (patch)
treec259c69091d221843b004017100a07479d7c17dc /README-SERIOUSLY.bestpractices.txt
parent26182f4b714f0297f0e628618218fb9a9e25fe8b (diff)
chan_sip: Clarify 'Forcerport' Setting Displayed When Running "sip show peers"
While looking at ASTERISK-22236, Walter Doekes pointed out that when running "sip show peers", the setting being displayed can be confusing. The display of "N" used to mean NAT (i.e. yes). The NAT setting has gone through many different changes resulting in the display of different characters to try and convey what the current setting is for 'Forcerport' (A for Auto and Forcerport is currently on, a for Auto but Forcerport is off, Y for yes, and N for no). During the initial code review to try and clarify these settings (especially since "N" no longer meant what it used to mean in prior versions of Asterisk), Mark Michelson suggested using the full space available to display the settings which helped to make the settings very clear. That was a great suggestion. Therefore, this patch does the following: * The column for 'Forcerport' now will show: Auto (Yes), Auto (No), Yes, or No. * A column for the 'Comedia' setting has been added. It too will display the setting in a non-cryptic way: Auto (Yes), Auto (No), Yes, or No. * UPGRADE.txt has been updated to document this change. (closes issue ASTERISK-22728) Reported by: Walter Doekes Tested by: Michael L. Young Patches: asterisk-forcerport-display-clarification_v3.diff uploaded by Michael L. Young (license 5026) Review: https://reviewboard.asterisk.org/r/2941 ........ Merged revisions 402111 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 402112 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'README-SERIOUSLY.bestpractices.txt')
0 files changed, 0 insertions, 0 deletions