diff options
author | Alexandr Anikin <may@telecom-service.ru> | 2012-05-03 15:05:14 +0000 |
---|---|---|
committer | Alexandr Anikin <may@telecom-service.ru> | 2012-05-03 15:05:14 +0000 |
commit | 0fe5050553bd20aad9657aeb9dca24be1a18fb69 (patch) | |
tree | d5d328d1bd9de50a96b05e87c8ce53680615ae55 /addons/ooh323c/src/ooh323.c | |
parent | 474612d7f727ba4520ba57c5d00c01111d84ea29 (diff) |
Fix warning of Coverity Static analysis, change H225ProtocolIdentifier
from value to pointer per functions that use this.
(close issue ASTERISK-19670)
Reported by: Matt Jordan
Patches:
ASTERISK-19670.patch (License #5415)
........
Merged revisions 365159 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 365160 from http://svn.asterisk.org/svn/asterisk/branches/10
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@365161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'addons/ooh323c/src/ooh323.c')
-rw-r--r-- | addons/ooh323c/src/ooh323.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/addons/ooh323c/src/ooh323.c b/addons/ooh323c/src/ooh323.c index 2b8dcf139..cdf187dad 100644 --- a/addons/ooh323c/src/ooh323.c +++ b/addons/ooh323c/src/ooh323.c @@ -40,7 +40,7 @@ int ooOnReceivedCallProceeding(OOH323CallData *call, Q931Message *q931Msg); int ooOnReceivedAlerting(OOH323CallData *call, Q931Message *q931Msg); int ooOnReceivedProgress(OOH323CallData *call, Q931Message *q931Msg); int ooHandleDisplayIE(OOH323CallData *call, Q931Message *q931Msg); -int ooHandleH2250ID (OOH323CallData *call, H225ProtocolIdentifier protocolIdentifier); +int ooHandleH2250ID (OOH323CallData *call, H225ProtocolIdentifier* protocolIdentifier); int ooHandleDisplayIE(OOH323CallData *call, Q931Message *q931Msg) { Q931InformationElement* pDisplayIE; @@ -58,10 +58,10 @@ int ooHandleDisplayIE(OOH323CallData *call, Q931Message *q931Msg) { return OO_OK; } -int ooHandleH2250ID (OOH323CallData *call, H225ProtocolIdentifier protocolIdentifier) { - if (!call->h225version && (protocolIdentifier.numids >= 6) && - (protocolIdentifier.subid[3] == 2250)) { - call->h225version = protocolIdentifier.subid[5]; +int ooHandleH2250ID (OOH323CallData *call, H225ProtocolIdentifier* protocolIdentifier) { + if (!call->h225version && (protocolIdentifier->numids >= 6) && + (protocolIdentifier->subid[3] == 2250)) { + call->h225version = protocolIdentifier->subid[5]; OOTRACEDBGC4("Extract H.225 remote version, it's %d, (%s, %s)\n", call->h225version, call->callType, call->callToken); @@ -388,7 +388,7 @@ int ooOnReceivedSetup(OOH323CallData *call, Q931Message *q931Msg) "%s\n", call->callType, call->callToken); return OO_FAILED; } - ooHandleH2250ID(call, setup->protocolIdentifier); + ooHandleH2250ID(call, &setup->protocolIdentifier); memcpy(call->callIdentifier.guid.data, setup->callIdentifier.guid.data, setup->callIdentifier.guid.numocts); call->callIdentifier.guid.numocts = setup->callIdentifier.guid.numocts; @@ -644,7 +644,7 @@ int ooOnReceivedCallProceeding(OOH323CallData *call, Q931Message *q931Msg) return OO_FAILED; } - ooHandleH2250ID(call, callProceeding->protocolIdentifier); + ooHandleH2250ID(call, &callProceeding->protocolIdentifier); /* Handle fast-start */ if(OO_TESTFLAG (call->flags, OO_M_FASTSTART)) { @@ -873,7 +873,7 @@ int ooOnReceivedAlerting(OOH323CallData *call, Q931Message *q931Msg) } return OO_FAILED; } - ooHandleH2250ID(call, alerting->protocolIdentifier); + ooHandleH2250ID(call, &alerting->protocolIdentifier); /*Handle fast-start */ if(OO_TESTFLAG (call->flags, OO_M_FASTSTART) && !OO_TESTFLAG(call->flags, OO_M_FASTSTARTANSWERED)) @@ -1110,7 +1110,7 @@ int ooOnReceivedProgress(OOH323CallData *call, Q931Message *q931Msg) } return OO_FAILED; } - ooHandleH2250ID(call, progress->protocolIdentifier); + ooHandleH2250ID(call, &progress->protocolIdentifier); /*Handle fast-start */ if(OO_TESTFLAG (call->flags, OO_M_FASTSTART) && !OO_TESTFLAG(call->flags, OO_M_FASTSTARTANSWERED)) @@ -1354,7 +1354,7 @@ int ooOnReceivedSignalConnect(OOH323CallData* call, Q931Message *q931Msg) } return OO_FAILED; } - ooHandleH2250ID(call, connect->protocolIdentifier); + ooHandleH2250ID(call, &connect->protocolIdentifier); /*Handle fast-start */ if(OO_TESTFLAG (call->flags, OO_M_FASTSTART) && !OO_TESTFLAG (call->flags, OO_M_FASTSTARTANSWERED)) @@ -1853,7 +1853,7 @@ int ooOnReceivedFacility(OOH323CallData *call, Q931Message * pQ931Msg) facility = pH323UUPdu->h323_message_body.u.facility; if(facility) { - ooHandleH2250ID(call, facility->protocolIdentifier); + ooHandleH2250ID(call, &facility->protocolIdentifier); /* Depending on the reason of facility message handle the message */ if(facility->reason.t == T_H225FacilityReason_transportedInformation) { |