diff options
| author | Russell Bryant <russell@russellbryant.com> | 2006-01-21 08:13:12 +0000 |
|---|---|---|
| committer | Russell Bryant <russell@russellbryant.com> | 2006-01-21 08:13:12 +0000 |
| commit | 7ad681adc8d5e616165b4d3e6750f2995e782d57 (patch) | |
| tree | 368912509e968ce6178e8e9586490a3e9edbac0e /apps/app_exec.c | |
| parent | 847260bb77455e6da12b3847c524741cc1458ce1 (diff) | |
remove lots of useless checks of the result of ast_strdupa
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'apps/app_exec.c')
| -rw-r--r-- | apps/app_exec.c | 33 |
1 files changed, 14 insertions, 19 deletions
diff --git a/apps/app_exec.c b/apps/app_exec.c index 9759455ac..b2a45dc93 100644 --- a/apps/app_exec.c +++ b/apps/app_exec.c @@ -73,27 +73,22 @@ static int exec_exec(struct ast_channel *chan, void *data) /* Check and parse arguments */ if (data) { - s = ast_strdupa((char *)data); + s = ast_strdupa(data); + appname = strsep(&s, "("); if (s) { - appname = strsep(&s, "("); - if (s) { - endargs = strrchr(s, ')'); - if (endargs) - *endargs = '\0'; - pbx_substitute_variables_helper(chan, s, args, MAXRESULT - 1); - } - if (appname) { - app = pbx_findapp(appname); - if (app) { - res = pbx_exec(chan, app, args, 1); - } else { - ast_log(LOG_WARNING, "Could not find application (%s)\n", appname); - res = -1; - } + endargs = strrchr(s, ')'); + if (endargs) + *endargs = '\0'; + pbx_substitute_variables_helper(chan, s, args, MAXRESULT - 1); + } + if (appname) { + app = pbx_findapp(appname); + if (app) { + res = pbx_exec(chan, app, args, 1); + } else { + ast_log(LOG_WARNING, "Could not find application (%s)\n", appname); + res = -1; } - } else { - ast_log(LOG_ERROR, "Out of memory\n"); - res = -1; } } |