diff options
author | StefanEng86 <stefanen@kth.se> | 2017-09-15 09:59:59 +0200 |
---|---|---|
committer | Joshua Colp <jcolp@digium.com> | 2017-09-25 07:02:28 -0500 |
commit | d0d4b139fcc19469ce170e223ac79e249c0d3c22 (patch) | |
tree | 7b399456c858477557eb2af831cfac83629b9611 /apps/app_playtones.c | |
parent | fc2d3e7e8123e0d6f06c27974abb000a6c299490 (diff) |
app_queue: Only do announcement logic between ringing cycles
This patch reverts the change by patch 2263 from old reviewboard.
Note that reverting that 2263-patch still preserves the behaviour that
the commit log of the 2263-patch claimed to add. The reason for this is:
The function wait_for_answer is only called from try_calling which
in turn is only called from the main for loop in queue_exec, and
earlier in that loop we already check the things that's removed by
this patch. There's no need to check those things twice each loop
iteration, and I think the proper place to check it is before each
ringing cycle. By checking it in wait_for_answer, you allow the issue
explained in the jira - that the head caller hears announcements while
the agents' sip phones are actively ringing.
Reported-by: Stefan Engström
Tested-by: Stefan Engström
ASTERISK-27216 #close
Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0
Diffstat (limited to 'apps/app_playtones.c')
0 files changed, 0 insertions, 0 deletions