diff options
| author | Russell Bryant <russell@russellbryant.com> | 2005-10-19 18:19:02 +0000 |
|---|---|---|
| committer | Russell Bryant <russell@russellbryant.com> | 2005-10-19 18:19:02 +0000 |
| commit | 4aa7912057e83f052e94637f0b1a10026fe14558 (patch) | |
| tree | 5fee3540f8d72d45cd1b2e5bf15e5860581dd4f8 /apps/app_system.c | |
| parent | e5afdbbe160b3267df769c9f04c04c6f152b1c94 (diff) | |
Massive cleanups to applications for LOCAL_USER handling and some other things.
In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application. An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'apps/app_system.c')
| -rwxr-xr-x | apps/app_system.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/apps/app_system.c b/apps/app_system.c index 00fed1058..6aa71f104 100755 --- a/apps/app_system.c +++ b/apps/app_system.c @@ -89,11 +89,13 @@ static int system_exec_helper(struct ast_channel *chan, void *data, int failmode { int res=0; struct localuser *u; - if (!data) { + + if (!data || ast_strlen_zero(data)) { ast_log(LOG_WARNING, "System requires an argument(command)\n"); pbx_builtin_setvar_helper(chan, chanvar, "FAILURE"); return failmode; } + LOCAL_USER_ADD(u); /* Do our thing here */ @@ -120,6 +122,7 @@ static int system_exec_helper(struct ast_channel *chan, void *data, int failmode } LOCAL_USER_REMOVE(u); + return res; } |