Massive cleanups to applications for LOCAL_USER handling and some other things.

In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application.  An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6832 65c4cc65-6c06-0410-ace0-fbb531ad65f3

1 files changed, 8 insertions, 1 deletions

diff --git a/apps/app_while.c b/apps/app_while.c
index 49c631221..4f6a54144 100755
--- a/apps/app_while.c
+++ b/apps/app_while.c
@@ -84,7 +84,14 @@ static int execif_exec(struct ast_channel *chan, void *data) {
 	struct ast_app *app = NULL;
 
 	LOCAL_USER_ADD(u);
-	expr = ast_strdupa((char *) data);
+
+	expr = ast_strdupa(data);
+	if (!expr) {
+		ast_log(LOG_ERROR, "Out of memory\n");
+		LOCAL_USER_REMOVE(u);
+		return -1;
+	}
+
 	if ((myapp = strchr(expr,'|'))) {
 		*myapp = '\0';
 		myapp++;