diff options
| author | Luigi Rizzo <rizzo@icir.org> | 2006-04-19 15:15:03 +0000 |
|---|---|---|
| committer | Luigi Rizzo <rizzo@icir.org> | 2006-04-19 15:15:03 +0000 |
| commit | 2bdcaa4849b26167cce548e9d1b0da0d2719b1fc (patch) | |
| tree | 40c5d7d2249572423f8f4a0ee197150d349c7cba /apps | |
| parent | 25eb0525d9bc6e01f5d2ae53ef81098bc9722ed5 (diff) | |
extract a common condition.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/app_dial.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/apps/app_dial.c b/apps/app_dial.c index c1a790b66..c6e2c6411 100644 --- a/apps/app_dial.c +++ b/apps/app_dial.c @@ -608,21 +608,21 @@ static struct ast_channel *wait_for_answer(struct ast_channel *in, struct dial_l if (option_debug) ast_log(LOG_DEBUG, "Dunno what to do with control type %d\n", f->subclass); } - } else if (single && (f->frametype == AST_FRAME_VOICE) && - !(ast_test_flag(outgoing, OPT_RINGBACK|OPT_MUSICBACK))) { - if (ast_write(in, f)) - ast_log(LOG_WARNING, "Unable to forward voice frame\n"); - } else if (single && (f->frametype == AST_FRAME_IMAGE) && - !(ast_test_flag(outgoing, OPT_RINGBACK|OPT_MUSICBACK))) { - if (ast_write(in, f)) - ast_log(LOG_WARNING, "Unable to forward image\n"); - } else if (single && (f->frametype == AST_FRAME_TEXT) && - !(ast_test_flag(outgoing, OPT_RINGBACK|OPT_MUSICBACK))) { - if (ast_write(in, f)) - ast_log(LOG_WARNING, "Unable to send text\n"); - } else if (single && (f->frametype == AST_FRAME_HTML) && !ast_test_flag(outgoing, DIAL_NOFORWARDHTML)) { - if(ast_channel_sendhtml(in, f->subclass, f->data, f->datalen) == -1) - ast_log(LOG_WARNING, "Unable to send URL\n"); + } else if (single) { + /* XXX are we sure the logic is correct ? or we should just switch on f->frametype ? */ + if (f->frametype == AST_FRAME_VOICE && !ast_test_flag(outgoing, OPT_RINGBACK|OPT_MUSICBACK)) { + if (ast_write(in, f)) + ast_log(LOG_WARNING, "Unable to forward voice frame\n"); + } else if (f->frametype == AST_FRAME_IMAGE && !ast_test_flag(outgoing, OPT_RINGBACK|OPT_MUSICBACK)) { + if (ast_write(in, f)) + ast_log(LOG_WARNING, "Unable to forward image\n"); + } else if (f->frametype == AST_FRAME_TEXT && !ast_test_flag(outgoing, OPT_RINGBACK|OPT_MUSICBACK)) { + if (ast_write(in, f)) + ast_log(LOG_WARNING, "Unable to send text\n"); + } else if (f->frametype == AST_FRAME_HTML && !ast_test_flag(outgoing, DIAL_NOFORWARDHTML)) { + if (ast_channel_sendhtml(in, f->subclass, f->data, f->datalen) == -1) + ast_log(LOG_WARNING, "Unable to send URL\n"); + } } ast_frfree(f); } /* end for */ |