diff options
author | Richard Mudgett <rmudgett@digium.com> | 2013-07-26 21:10:24 +0000 |
---|---|---|
committer | Richard Mudgett <rmudgett@digium.com> | 2013-07-26 21:10:24 +0000 |
commit | 50aba6be3654e348960a3bda2312f7a913f5c160 (patch) | |
tree | ec7ae8a644b488d2891e9919c0bf7d2ee43fcd2e /apps | |
parent | b6f9b398308865fcb2c42995d4277e10ab9518e7 (diff) |
Improved feature limits interval hook implementaion.
* Fixed feature limits to not use special members of struct
ast_bridge_features.
* Fixed memory leak in off nominal paths of bridge_builtin_set_limits().
* Fixed off nominal path in ast_bridge_features_limits_construct() freeing
unallocated memory if it was not called by bridge_builtin_set_limits().
* Made bridge_builtin_interval_features.so unloadable.
* Simplified parking's use of its duration interval hook.
* Made BridgeWait S option not depend upon another module being loaded.
(closes issue ASTERISK-22107)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2701/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@395559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'apps')
-rw-r--r-- | apps/app_bridgewait.c | 30 |
1 files changed, 16 insertions, 14 deletions
diff --git a/apps/app_bridgewait.c b/apps/app_bridgewait.c index fc2c10697..bdfd87e62 100644 --- a/apps/app_bridgewait.c +++ b/apps/app_bridgewait.c @@ -201,32 +201,34 @@ AST_APP_OPTIONS(bridgewait_opts, { AST_APP_OPTION_ARG('S', MUXFLAG_TIMEOUT, OPT_ARG_TIMEOUT), }); +static int bridgewait_timeout_callback(struct ast_bridge *bridge, struct ast_bridge_channel *bridge_channel, void *hook_pvt) +{ + ast_verb(3, "Channel %s timed out.\n", ast_channel_name(bridge_channel->chan)); + ast_bridge_channel_leave_bridge(bridge_channel, BRIDGE_CHANNEL_STATE_END); + return -1; +} + static int apply_option_timeout(struct ast_bridge_features *features, char *duration_arg) { - struct ast_bridge_features_limits hold_limits; + unsigned int duration; if (ast_strlen_zero(duration_arg)) { - ast_log(LOG_ERROR, "No duration value provided for the timeout ('S') option.\n"); + ast_log(LOG_ERROR, "Timeout option 'S': No value provided.\n"); return -1; } - - if (ast_bridge_features_limits_construct(&hold_limits)) { - ast_log(LOG_ERROR, "Could not construct duration limits. Bridge canceled.\n"); + if (sscanf(duration_arg, "%u", &duration) != 1 || duration == 0) { + ast_log(LOG_ERROR, "Timeout option 'S': Invalid value provided '%s'.\n", + duration_arg); return -1; } - if (sscanf(duration_arg, "%u", &hold_limits.duration) != 1 - || hold_limits.duration == 0) { - ast_log(LOG_ERROR, "Duration value provided for the timeout ('S') option must be greater than 0\n"); - ast_bridge_features_limits_destroy(&hold_limits); + duration *= 1000; + if (ast_bridge_interval_hook(features, duration, bridgewait_timeout_callback, + NULL, NULL, AST_BRIDGE_HOOK_REMOVE_ON_PULL)) { + ast_log(LOG_ERROR, "Timeout option 'S': Could not create timer.\n"); return -1; } - /* Limits struct holds time as milliseconds, so muliply 1000x */ - hold_limits.duration *= 1000; - ast_bridge_features_set_limits(features, &hold_limits, AST_BRIDGE_HOOK_REMOVE_ON_PULL); - ast_bridge_features_limits_destroy(&hold_limits); - return 0; } |