diff options
author | Matt Jordan <mjordan@digium.com> | 2015-04-11 21:38:22 -0500 |
---|---|---|
committer | Corey Farrell <git@cfware.com> | 2015-04-13 03:48:57 -0400 |
commit | 4a58261694f1538a419dd869f87ea4590171a9f2 (patch) | |
tree | a8d3196d5b69f233f814ef3fa7a543c2ce50bd24 /cel | |
parent | 1174ef588dafe864fe3f2c1f8297690def8f85d1 (diff) |
git migration: Refactor the ASTERISK_FILE_VERSION macro
Git does not support the ability to replace a token with a version
string during check-in. While it does have support for replacing a
token on clone, this is somewhat sub-optimal: the token is replaced
with the object hash, which is not particularly easy for human
consumption. What's more, in practice, the source file version was often
not terribly useful. Generally, when triaging bugs, the overall version
of Asterisk is far more useful than an individual SVN version of a file. As a
result, this patch removes Asterisk's support for showing source file
versions.
Specifically, it does the following:
* Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
remove passing the version in with the macro. Other facilities
than 'core show file version' make use of the file names, such as
setting a debug level only on a specific file. As such, the act of
registering source files with the Asterisk core still has use. The
macro rename now reflects the new macro purpose.
* main/asterisk:
- Refactor the file_version structure to reflect that it no longer
tracks a version field.
- Remove the "core show file version" CLI command. Without the file
version, it is no longer useful.
- Remove the ast_file_version_find function. The file version is no
longer tracked.
- Rename ast_register_file_version/ast_unregister_file_version to
ast_register_file/ast_unregister_file, respectively.
* main/manager: Remove value from the Version key of the ModuleCheck
Action. The actual key itself has not been removed, as doing so would
absolutely constitute a backwards incompatible change. However, since
the file version is no longer tracked, there is no need to attempt to
include it in the Version key.
* UPGRADE: Add notes for:
- Modification to the ModuleCheck AMI Action
- Removal of the "core show file version" CLI command
Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
Diffstat (limited to 'cel')
-rw-r--r-- | cel/cel_custom.c | 2 | ||||
-rw-r--r-- | cel/cel_manager.c | 2 | ||||
-rw-r--r-- | cel/cel_odbc.c | 2 | ||||
-rw-r--r-- | cel/cel_pgsql.c | 2 | ||||
-rw-r--r-- | cel/cel_radius.c | 2 | ||||
-rw-r--r-- | cel/cel_sqlite3_custom.c | 2 | ||||
-rw-r--r-- | cel/cel_tds.c | 2 |
7 files changed, 7 insertions, 7 deletions
diff --git a/cel/cel_custom.c b/cel/cel_custom.c index edb009686..0c55e497b 100644 --- a/cel/cel_custom.c +++ b/cel/cel_custom.c @@ -35,7 +35,7 @@ #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +ASTERISK_REGISTER_FILE() #include "asterisk/paths.h" #include "asterisk/channel.h" diff --git a/cel/cel_manager.c b/cel/cel_manager.c index b3ff6a5de..bdf505b66 100644 --- a/cel/cel_manager.c +++ b/cel/cel_manager.c @@ -195,7 +195,7 @@ #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +ASTERISK_REGISTER_FILE() #include "asterisk/channel.h" #include "asterisk/cel.h" diff --git a/cel/cel_odbc.c b/cel/cel_odbc.c index 11e333097..480344499 100644 --- a/cel/cel_odbc.c +++ b/cel/cel_odbc.c @@ -33,7 +33,7 @@ #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +ASTERISK_REGISTER_FILE() #include <sys/types.h> #include <time.h> diff --git a/cel/cel_pgsql.c b/cel/cel_pgsql.c index 56a6069d4..bb4215199 100644 --- a/cel/cel_pgsql.c +++ b/cel/cel_pgsql.c @@ -44,7 +44,7 @@ #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +ASTERISK_REGISTER_FILE() #include <libpq-fe.h> diff --git a/cel/cel_radius.c b/cel/cel_radius.c index 79caf22f5..617ca660d 100644 --- a/cel/cel_radius.c +++ b/cel/cel_radius.c @@ -33,7 +33,7 @@ #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Rev$") +ASTERISK_REGISTER_FILE() #ifdef FREERADIUS_CLIENT #include <freeradius-client.h> diff --git a/cel/cel_sqlite3_custom.c b/cel/cel_sqlite3_custom.c index afa99f7dc..07407829c 100644 --- a/cel/cel_sqlite3_custom.c +++ b/cel/cel_sqlite3_custom.c @@ -41,7 +41,7 @@ #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +ASTERISK_REGISTER_FILE() #include <sqlite3.h> diff --git a/cel/cel_tds.c b/cel/cel_tds.c index a66115b71..30aa1fb0d 100644 --- a/cel/cel_tds.c +++ b/cel/cel_tds.c @@ -61,7 +61,7 @@ CREATE TABLE [dbo].[cel] ( #include "asterisk.h" -ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +ASTERISK_REGISTER_FILE() #include <time.h> #include <math.h> |