diff options
| author | Matthew Jordan <mjordan@digium.com> | 2015-04-08 11:45:05 +0000 |
|---|---|---|
| committer | Matthew Jordan <mjordan@digium.com> | 2015-04-08 11:45:05 +0000 |
| commit | b8fa8aa77534fae8cea46d67c15b49f9677879bb (patch) | |
| tree | 1d4088d8f73386445f3508cd53266a967271289b /channels/chan_pjsip.c | |
| parent | 016fba12e2d1e4ca8a48af0a2090cb8a6b5a2272 (diff) | |
clang compiler warnings: Fix pointer-bool-converesion warnings
This patch fixes several warnings pointed out by the clang compiler.
* chan_pjsip: Removed check for data->text, as it will always be non-NULL.
* app_minivm: Fixed evaluation of etemplate->locale, which will always
evaluate to 'true'. This patch changes the evaluation to use
ast_strlen_zero.
* app_queue:
- Fixed evaluation of qe->parent->monfmt, which always evaluates to
true. Instead, we just check to see if the dereferenced pointer
evaluates to true.
- Fixed evaluation of mem->state_interface, wrapping it with a call to
ast_strlen_zero.
* res_smdi: Wrapped search_msg->mesg_desk_term with calls to ast_strlen_zero.
Review: https://reviewboard.asterisk.org/r/4541
ASTERISK-24917
Reported by: dkdegroot
patches:
rb4541.patch submitted by dkdegroot (License 6600)
........
Merged revisions 434285 from http://svn.asterisk.org/svn/asterisk/branches/11
........
Merged revisions 434286 from http://svn.asterisk.org/svn/asterisk/branches/13
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@434287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'channels/chan_pjsip.c')
| -rw-r--r-- | channels/chan_pjsip.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c index 1277d559f..897aa2d49 100644 --- a/channels/chan_pjsip.c +++ b/channels/chan_pjsip.c @@ -1941,12 +1941,6 @@ static int sendtext(void *obj) .body_text = data->text }; - /* NOT ast_strlen_zero, because a zero-length message is specifically - * allowed by RFC 3428 (See section 10, Examples) */ - if (!data->text) { - return 0; - } - ast_debug(3, "Sending in dialog SIP message\n"); ast_sip_create_request("MESSAGE", data->session->inv_session->dlg, data->session->endpoint, NULL, NULL, &tdata); |