diff options
| author | Richard Mudgett <rmudgett@digium.com> | 2010-10-11 19:07:59 +0000 |
|---|---|---|
| committer | Richard Mudgett <rmudgett@digium.com> | 2010-10-11 19:07:59 +0000 |
| commit | d8b4b9509afc1db737ba0a7872d1a985e6082705 (patch) | |
| tree | f748df3f3a10ad94b7920a95138580b58710be64 /channels/chan_sip.c | |
| parent | 924793d6e6c9e2dc36ba398c5dbe99ef2e6b4fa9 (diff) | |
Add todo comment about handle_incoming() calling assumption.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@291115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'channels/chan_sip.c')
| -rw-r--r-- | channels/chan_sip.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 79408c046..26f0a3814 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -23799,6 +23799,7 @@ static void process_request_queue(struct sip_pvt *p, int *recount, int *nounlock struct sip_request *req; while ((req = AST_LIST_REMOVE_HEAD(&p->request_queue, next))) { + /*! \todo XXX if nounlock is nonzero we do not have the channel lock anymore. handle_incoming() assumes that it is locked. */ if (handle_incoming(p, req, &p->recv, recount, nounlock) == -1) { /* Request failed */ ast_debug(1, "SIP message could not be handled, bad request: %-70.70s\n", p->callid[0] ? p->callid : "<no callid>"); @@ -24024,6 +24025,7 @@ static int handle_request_do(struct sip_request *req, struct ast_sockaddr *addr) process_request_queue(p, &recount, &nounlock); } + /*! \todo XXX if nounlock is nonzero we do not have the channel lock anymore. handle_incoming() assumes that it is locked. */ if (handle_incoming(p, req, addr, &recount, &nounlock) == -1) { /* Request failed */ ast_debug(1, "SIP message could not be handled, bad request: %-70.70s\n", p->callid[0] ? p->callid : "<no callid>"); |