diff options
| author | Sean Bright <sean.bright@gmail.com> | 2017-12-07 10:52:39 -0500 |
|---|---|---|
| committer | Sean Bright <sean.bright@gmail.com> | 2017-12-08 13:27:42 -0600 |
| commit | f9c6f692053ac865d46cbf8843ab810dc66cba67 (patch) | |
| tree | 60bfe167eee2d096abe839803fdd4e4691f6c562 /channels/vgrabbers.c | |
| parent | 52de5a05f0f6bf534c0642a4f43daa562b5b9004 (diff) | |
utils: Add convenience function for setting fd flags
There are many places in the code base where we ignore the return value
of fcntl() when getting/setting file descriptior flags. This patch
introduces a convenience function that allows setting or clearing file
descriptor flags and will also log an error on failure for later
analysis.
Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7
Diffstat (limited to 'channels/vgrabbers.c')
| -rw-r--r-- | channels/vgrabbers.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/channels/vgrabbers.c b/channels/vgrabbers.c index 25817407e..169e59c5d 100644 --- a/channels/vgrabbers.c +++ b/channels/vgrabbers.c @@ -226,12 +226,8 @@ static void *grab_v4l1_open(const char *dev, struct fbuf_t *geom, int fps) v->b = *geom; b = &v->b; /* shorthand */ - i = fcntl(fd, F_GETFL); - if (-1 == fcntl(fd, F_SETFL, i | O_NONBLOCK)) { - /* non fatal, just emit a warning */ - ast_log(LOG_WARNING, "error F_SETFL for %s [%s]\n", - dev, strerror(errno)); - } + ast_fd_set_flags(fd, O_NONBLOCK); + /* set format for the camera. * In principle we could retry with a different format if the * one we are asking for is not supported. |