Update Makefile and Readme with warnings and current info

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1286 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2 files changed, 29 insertions, 11 deletions

diff --git a/channels/h323/Makefile b/channels/h323/Makefile
index b2ba3094b..688445195 100755
--- a/channels/h323/Makefile
+++ b/channels/h323/Makefile
@@ -16,9 +16,10 @@ ifndef ASTETCDIR
 ASTETCDIR=/etc/asterisk
 endif
 
-#Uncomment if u want to attempt to include the G.729 stuff
+# Uncomment if u want to attempt to include the G.729 stuff
 # This is a quick fix to work around the missing H323Capability
-# in Open H.323
+# in Open H.323. As of Open H.323 1.12.0 the H323Capability for
+# G.729 was removed due to legal reasons, use Open H.323 v1.11.7
 #
 #CFLAGS += -DWANT_G729
 #
@@ -26,6 +27,9 @@ endif
 #
 CFLAGS += -march=$(shell uname -m) -DPBYTE_ORDER=PLITTLE_ENDIAN
 
+
+#############################################
+#
 # Only change below if you know WTF your doing
 #
 CFLAGS += -DNDEBUG -DDO_CRASH -DDEBUG_THREADS
@@ -37,7 +41,8 @@ CFLAGS += -I$(PWLIBDIR)/include/ptlib/unix -I$(PWLIBDIR)/include
 CFLAGS += -I$(OPENH323DIR)/include -Wno-missing-prototypes -Wno-missing-declarations
 
 
-all: chan_h323.so
+all:   	chan_h323.so
+
 
 noshared: chan_h323_s.so
 optnoshared: chan_h323_s.so
@@ -46,7 +51,7 @@ debug:	chan_h323_d.so
 
 install: all
 	install -m 755 chan_h323.so $(ASTERISKDIR)
-	@echo " +----- chan_h323 Installation Complete ----- +"
+	@echo " + ---- chan_h323 Installation Complete ----- +"
 	@echo " +                                            +"
 	@echo " + chan_h323 has successfully been installed. +"
 	@echo " + If you would like to install the sample    +"
@@ -55,7 +60,8 @@ install: all
 	@echo " +                                            +"
 	@echo " +               $(MAKE) samples                 +"
 	@echo " +                                            +"
-	@echo " +                                            +"
+	@echo " + ------------------------------------------ +"
+	@echo " "
  
 
 samples: 
@@ -65,12 +71,19 @@ samples:
 	install h323.conf.sample $(ASTETCDIR)/h323.conf
  
 
-chan_h323.o:	chan_h323.c
+chan_h323.o: chan_h323.c
+	@echo " + --------------- chan_h323 ---------------- +"
+	@echo " +	                                      +"
+	@echo " + 	    Please read the README            +"
+	@echo " +    Doing so will save you many headaches   +"
+	@echo " +                                            +"
+	@echo " + ------------------------------------------ +"
 	$(CC) -g -c -o $@ $(CFLAGS) $<
 ast_h323.o:	ast_h323.cpp
 	g++ -g -c -o $@ $(CFLAGS) $<
 
 chan_h323.so:	chan_h323.o ast_h323.o
+	
 	g++  -g -shared -Xlinker -x -o chan_h323.so chan_h323.o ast_h323.o -L$(PWLIBDIR)/lib  -lpt_linux_x86_r -L$(OPENH323DIR)/lib -lh323_linux_x86_r -L/usr/lib -lpthread -ldl -lcrypto -lssl -lexpat
 
 chan_h323_d.so:	chan_h323.o ast_h323.o
diff --git a/channels/h323/README b/channels/h323/README
index 438067419..32e3c2b37 100755
--- a/channels/h323/README
+++ b/channels/h323/README
@@ -32,6 +32,9 @@ As of June 16th, 2003 the release version of Open H.323 does not compile
 due to the G729Capability is missing. If you want G.729 support see
 the Makefile.  
 
+Some chan_h323 users have reported success when using newer versions
+of Open H.323. We haven't personally tested this and will not be able
+to assist you if you have 'issues'. Sorry.
 
 
 
@@ -55,7 +58,7 @@ make clean opt
 cd asterisk/channels/h323
 make clean install   
 
-(Note: Open H.323 or PWLib never get a 'make install')
+(Note: Open H.323 or PWLib never get a 'make install' so don't do it)
  
 
 Most common run-time error:
@@ -80,11 +83,11 @@ want to recompile.
 
 
 If you still have trouble please contact 'JerJer' in #Asterisk on 
-irc.freenode.net or send and email to jj@indie.org
+irc.freenode.net or send and email to jj@nufone.net
 
 If you happen to be lucky enough to segfault this code please run a 
 backtrace  and send me the gory details. Segmentation faults are not
- tolerated!
+tolerated, no matter what Distro you run!
 
 bt example:
 
@@ -97,7 +100,7 @@ Segmentation Fault (core dumped)
 core.1976
 
 # gdb /usr/sbin/asterisk core.1976
-...
+...lots of useless garbage here..
 (gdb) bt
 
 Send whatever shows up right after the 'bt'
@@ -108,5 +111,7 @@ in the full console mode (-c) and turn on 'h.323  debug'. A nice way
 to capture everything is to use the utility called 'script' (man script) 
 
 
-Jeremy McNamara, President
+
+Jeremy McNamara
+Chief Cook and Bottle Washer
 The NuFone Network