diff options
author | Torrey Searle <torrey@voxbone.com> | 2017-07-28 14:53:44 +0200 |
---|---|---|
committer | Torrey Searle <torrey@voxbone.com> | 2017-08-09 15:54:45 +0200 |
commit | be8cb75dd2e95f73f47d0bf2c1ef50a84d0d4226 (patch) | |
tree | 9fba9b77f041873c8f62cd911258ab9677c19673 /channels | |
parent | 709b837c35197d399d31d1db0947a87d5cdb0cf2 (diff) |
res_rtp_asterisk: Make P2P bridge Asymmetric codec aware
Introduce a new property to rtp-engine to make it aware of
the desire for assymetric codecs or not. If asymmetric codecs
is not allowed, the bridge will compare read/write formats
and shut down the p2p bridge if needed
ASTERISK-26745 #close
Change-Id: I0d9c83e5356df81661e58d40a8db565833501a6f
Diffstat (limited to 'channels')
-rw-r--r-- | channels/chan_pjsip.c | 21 |
1 files changed, 14 insertions, 7 deletions
diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c index ebda6c7ee..4a24fa689 100644 --- a/channels/chan_pjsip.c +++ b/channels/chan_pjsip.c @@ -797,14 +797,13 @@ static struct ast_frame *chan_pjsip_read_stream(struct ast_channel *ast) return f; } - if (ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), f->subclass.format) == AST_FORMAT_CMP_NOT_EQUAL) { - ast_debug(1, "Oooh, got a frame with format of %s on channel '%s' when it has not been negotiated\n", - ast_format_get_name(f->subclass.format), ast_channel_name(ast)); - - ast_frfree(f); - return &ast_null_frame; - } + session = channel->session; + /* + * Asymmetric RTP only has one native format set at a time. + * Therefore we need to update the native format to the current + * raw read format BEFORE the native format check + */ if (!session->endpoint->asymmetric_rtp_codec && ast_format_cmp(ast_channel_rawwriteformat(ast), f->subclass.format) == AST_FORMAT_CMP_NOT_EQUAL) { struct ast_format_cap *caps; @@ -831,6 +830,14 @@ static struct ast_frame *chan_pjsip_read_stream(struct ast_channel *ast) } } + if (ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), f->subclass.format) == AST_FORMAT_CMP_NOT_EQUAL) { + ast_debug(1, "Oooh, got a frame with format of %s on channel '%s' when it has not been negotiated\n", + ast_format_get_name(f->subclass.format), ast_channel_name(ast)); + + ast_frfree(f); + return &ast_null_frame; + } + if (session->dsp) { int dsp_features; |